Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.1, 1.2.2, 1.1.1, 1.1.2
    • Fix Version/s: 1.2.3, 2.0.3, 1.1.3
    • Component/s: None
    • Labels:
      None

      Description

      in combination with spring security it's useful to use jsf input components without value bindings.
      furthermore, it's useful to support faster prototyping.

      original issue text: NPE in PropertyValidatorGroupProvider Line 83

      1. EXTVAL-54_and_EXTVAL-55.patch
        27 kB
        Gerhard Petracek
      2. EXTVAL-54_and_EXTVAL-55_v2.patch
        47 kB
        Gerhard Petracek

        Activity

        Hide
        Gerhard Petracek added a comment -

        hi thomas,

        i think you mean PropertyValidationGroupProvider.

        are you using icefaces?

        regards,
        gerhard

        Show
        Gerhard Petracek added a comment - hi thomas, i think you mean PropertyValidationGroupProvider. are you using icefaces? regards, gerhard
        Hide
        Thomas Wilhelm added a comment -

        Hi Gerhard,

        PropertyValidationGroupProvider is what I mean. I am using RichFaces with extval 1.2.3.-Snapshot build. I was trying to get Bean Validation working although I know it is not meant to be used by now (it is commented out in the maven build). I am currently using Property Validator but would definitly like to try JSR303.

        Thx in advance,
        Thomas

        Show
        Thomas Wilhelm added a comment - Hi Gerhard, PropertyValidationGroupProvider is what I mean. I am using RichFaces with extval 1.2.3.-Snapshot build. I was trying to get Bean Validation working although I know it is not meant to be used by now (it is commented out in the maven build). I am currently using Property Validator but would definitly like to try JSR303. Thx in advance, Thomas
        Hide
        Gerhard Petracek added a comment -

        hi thomas,

        i see!

        could you please provide a bit more information about the bound property. i've a demo-webapp with jsr 303 constraints which works pretty fine.
        the line you mentioned uses propertyDetails as well as the key. is propertyDetails null?

        regards,
        gerhard

        Show
        Gerhard Petracek added a comment - hi thomas, i see! could you please provide a bit more information about the bound property. i've a demo-webapp with jsr 303 constraints which works pretty fine. the line you mentioned uses propertyDetails as well as the key. is propertyDetails null? regards, gerhard
        Hide
        Thomas Wilhelm added a comment -

        Hi Gerhard,

        actually my application now generally works using bean validation together with extval. The thing that causes the NPE is the login page. This does not use a value mapping but rather sends "pure" HTML params. This is due to the fact that I am using Spring Security for the whole login process. Thus the login ist handled completely by the spring servlet filter. The propertyDetails are null in this case.

        I have tried to fix this issue patching PropertyValidationGroupProvider and BeanValidationInterceptor which seams to work. I am not sure however if this simple fix is working for all cases.

        regards,

        Thomas

        Show
        Thomas Wilhelm added a comment - Hi Gerhard, actually my application now generally works using bean validation together with extval. The thing that causes the NPE is the login page. This does not use a value mapping but rather sends "pure" HTML params. This is due to the fact that I am using Spring Security for the whole login process. Thus the login ist handled completely by the spring servlet filter. The propertyDetails are null in this case. I have tried to fix this issue patching PropertyValidationGroupProvider and BeanValidationInterceptor which seams to work. I am not sure however if this simple fix is working for all cases. regards, Thomas
        Hide
        Gerhard Petracek added a comment -

        hi thomas,

        if propertyDetails is null, there is no bound property or there is a problem with the extraction of it.
        does that mean you have a jsf page with jsf input components as login screen without a value binding?

        regards,
        gerhard

        Show
        Gerhard Petracek added a comment - hi thomas, if propertyDetails is null, there is no bound property or there is a problem with the extraction of it. does that mean you have a jsf page with jsf input components as login screen without a value binding? regards, gerhard
        Hide
        Thomas Wilhelm added a comment -

        Hi Gerhard,

        exactly. I have no value binding on these components. Spring Security will intercept all calls and will read the value from the http params directly. This way you can use "wrap" the security features around almost any web app without change.

        regards,
        Thomas

        Show
        Thomas Wilhelm added a comment - Hi Gerhard, exactly. I have no value binding on these components. Spring Security will intercept all calls and will read the value from the http params directly. This way you can use "wrap" the security features around almost any web app without change. regards, Thomas
        Hide
        Gerhard Petracek added a comment -

        hi thomas,

        i see. yes we can talk about including a functionality which is already provided by:
        http://code.google.com/p/os890/source/browse/#svn/trunk/java/web/jsf/extval/prototyping
        as base principle.

        regards,
        gerhard

        Show
        Gerhard Petracek added a comment - hi thomas, i see. yes we can talk about including a functionality which is already provided by: http://code.google.com/p/os890/source/browse/#svn/trunk/java/web/jsf/extval/prototyping as base principle. regards, gerhard
        Hide
        Gerhard Petracek added a comment -

        a first draft to solve both

        Show
        Gerhard Petracek added a comment - a first draft to solve both
        Hide
        Gerhard Petracek added a comment -

        hi thomas,

        you can already test the patch (if you would like to).
        in the meantime i'll think about details and alternatives.

        regards,
        gerhard

        Show
        Gerhard Petracek added a comment - hi thomas, you can already test the patch (if you would like to). in the meantime i'll think about details and alternatives. regards, gerhard
        Hide
        Gerhard Petracek added a comment -

        approach which allows the trinidad support module to use the new mechanism as well

        Show
        Gerhard Petracek added a comment - approach which allows the trinidad support module to use the new mechanism as well
        Hide
        Gerhard Petracek added a comment -

        hi thomas,

        i committed the changes.
        could you please try it. if you are fine with the changes as well, i'll close this issue.

        regards,
        gerhard

        Show
        Gerhard Petracek added a comment - hi thomas, i committed the changes. could you please try it. if you are fine with the changes as well, i'll close this issue. regards, gerhard
        Hide
        Thomas Wilhelm added a comment -

        Hi Herhard,

        it works now. Thank you very much.

        Regards,
        Thomas

        Show
        Thomas Wilhelm added a comment - Hi Herhard, it works now. Thank you very much. Regards, Thomas

          People

          • Assignee:
            Gerhard Petracek
            Reporter:
            Thomas Wilhelm
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development