MyFaces Extensions Scripting
  1. MyFaces Extensions Scripting
  2. EXTSCRIPT-115

Better logging when developer specifies a non existent source directory

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-Final
    • Fix Version/s: 1.0-Final
    • Component/s: Core
    • Labels:
      None

      Description

      When I make a typo in a source directory, like:
      D:/dev/work/idea9/parleys/web-html5/src/main/jav (notice the missing 'a' at the end)

      I don't get a message suggesting I made an error, but ExtScript fails silently by not reloading the classes in this directory.

      There is a javac message in the log:
      INFO: [EXT-SCRITPING] starting class dependency scan
      18-apr-2010 16:53:24 org.apache.myfaces.extensions.scripting.loaders.java.jsr199.JSR199Compiler compile
      INFO: [EXT-SCRIPTING] Doing a full recompile
      javacTask: no source files
      Usage: javacTask <options> <source files>
      use -help for a list of possible options

      But it's easy to miss it because MyFaces and other frameworks also emit a lot of logging. Something heavier (ERROR level or maybe an initializer exception) might be better, so the user won't get confused/angry.

      I think such a check is even more appropriate because file paths in Java are always error-prone (I always make mistakes with paths)...

        Activity

        Hide
        Werner Punz added a comment - - edited

        Yes true the logging can be improved in this area, I will fix that also before 1.0.
        Btw. thanks for the testing, while all this errors are minor, it is good to have them found out so that I can fix them before 1.0.

        Show
        Werner Punz added a comment - - edited Yes true the logging can be improved in this area, I will fix that also before 1.0. Btw. thanks for the testing, while all this errors are minor, it is good to have them found out so that I can fix them before 1.0.
        Hide
        Werner Punz added a comment -

        done... thanks for reporting it, this should help the users tremendously

        Show
        Werner Punz added a comment - done... thanks for reporting it, this should help the users tremendously

          People

          • Assignee:
            Werner Punz
            Reporter:
            Jan-Kees van Andel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development