MyFaces CODI
  1. MyFaces CODI
  2. EXTCDI-249

move PropertyExpressionInterpreter and SystemPropertyExpressionInterpreter to core-api

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.2
    • Fix Version/s: 1.0.4
    • Component/s: Core
    • Labels:
      None

      Description

      the SystemPropertyExpressionInterpreter is pretty often very useful.
      Since PropertyExpressionInterpreter and SystemPropertyExpressionInterpreter are only a slim shim over the AbstractPropertyExpressionInterpreter (which is already in core-api), we should move them over to core-api as well.

        Activity

        Mark Struberg created issue -
        Hide
        Mark Struberg added a comment -

        we should consider introducing interfaces for them in core-api and have the implementations in core-impl.
        That might be a working solution.

        Show
        Mark Struberg added a comment - we should consider introducing interfaces for them in core-api and have the implementations in core-impl. That might be a working solution.
        Hide
        Gerhard Petracek added a comment -

        it isn't needed for PropertyExpressionInterpreter because it's the default implementation.

        imo we don't need such an indirection right now, because it's mainly an extension point for concrete projects and we won't have that many alternatives in our code-base. currently it's just SystemPropertyExpressionInterpreter. -> it would be enough to move it to org.apache.myfaces.extensions.cdi.core.api.interpreter

        (as soon as we need such an indirection (it's never needed by users for custom implementations), we can add it easily).

        Show
        Gerhard Petracek added a comment - it isn't needed for PropertyExpressionInterpreter because it's the default implementation. imo we don't need such an indirection right now, because it's mainly an extension point for concrete projects and we won't have that many alternatives in our code-base. currently it's just SystemPropertyExpressionInterpreter. -> it would be enough to move it to org.apache.myfaces.extensions.cdi.core.api.interpreter (as soon as we need such an indirection (it's never needed by users for custom implementations), we can add it easily).
        Gerhard Petracek made changes -
        Field Original Value New Value
        Assignee Gerhard Petracek [ gpetracek ]
        Gerhard Petracek made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Gerhard Petracek made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 1.0.4 [ 12319465 ]
        Resolution Fixed [ 1 ]
        Gerhard Petracek made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Gerhard Petracek
            Reporter:
            Mark Struberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development