MyFaces CODI
  1. MyFaces CODI
  2. EXTCDI-220

@PreDestroy not called when closing sub-groups

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.0.2
    • Component/s: Core
    • Labels:
      None

      Description

      currently we don't invoke Contextual#destroy() while removing sub-groups. grouped conversations aren't affected - only subgroups.

        Activity

        Hide
        Gerhard Petracek added a comment -

        BeanStorage#resetStorage destroys it properly via beanHolder.getBean().destroy(...)

        Show
        Gerhard Petracek added a comment - BeanStorage#resetStorage destroys it properly via beanHolder.getBean().destroy(...)
        Hide
        Mark Struberg added a comment -

        JsfWindowContext#closeSubGroups and a few others call to EditableConversation#removeBeanEntry()

        Show
        Mark Struberg added a comment - JsfWindowContext#closeSubGroups and a few others call to EditableConversation#removeBeanEntry()
        Hide
        Gerhard Petracek added a comment -

        ok - but it isn't related to the ViewAccessScoped.
        affected is EditableConversation#removeBeanEntry which is new and only used for grouped conversations and there only for subgroups

        Show
        Gerhard Petracek added a comment - ok - but it isn't related to the ViewAccessScoped. affected is EditableConversation#removeBeanEntry which is new and only used for grouped conversations and there only for subgroups
        Hide
        Mark Struberg added a comment -

        yes true, it's not a general ViewAccessScoped problem but rather a subgroup one. will fix the title of the issue

        Show
        Mark Struberg added a comment - yes true, it's not a general ViewAccessScoped problem but rather a subgroup one. will fix the title of the issue
        Hide
        Mark Struberg added a comment -

        fixed in r1163305.

        Show
        Mark Struberg added a comment - fixed in r1163305.
        Hide
        Gerhard Petracek added a comment -

        refixed in r1163312

        Show
        Gerhard Petracek added a comment - refixed in r1163312
        Hide
        Mark Struberg added a comment -

        Imo the last commit should get rollbacked. Removal from teh BeanStorage doesn't automatically mean the object wont be used anymore.
        A use case: bean history to get rid of the browser back button problem. The Contextual#destroy must only be called if the instance get dropped from the history. But the BeanStorage has not sufficient knowledge about this!

        Show
        Mark Struberg added a comment - Imo the last commit should get rollbacked. Removal from teh BeanStorage doesn't automatically mean the object wont be used anymore. A use case: bean history to get rid of the browser back button problem. The Contextual#destroy must only be called if the instance get dropped from the history. But the BeanStorage has not sufficient knowledge about this!

          People

          • Assignee:
            Mark Struberg
            Reporter:
            Mark Struberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development