Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      mvn clean jetty:run-exploded -PjettyConfig -Djsf=mojarra
      leads to an exception because the bean-validation impl. is missing and mojarra behaves differently.

      To reproduce:

      • Use the archetype (currently) #11
      • mvn clean jetty:run-exploded -PjettyConfig -Djsf=mojarra
      • Enter something into the input-field and submit the form.

      I've attached a pom that depends on org.apache.bval.bval-core and bval-jsr303 in the mojarra profile (not sure if both are needed?)

      We should maybe also add a commented section, that has the dependencies for using bval/extval, so it is easy to add the Impl.

      Imre

      1. pom.xml.zip
        2 kB
        Imre Osswald

        Issue Links

          Activity

          Hide
          Imre Osswald added a comment -

          Here is a pom, that adds org.apache.bval.* to the mojarra profile.

          Show
          Imre Osswald added a comment - Here is a pom, that adds org.apache.bval.* to the mojarra profile.
          Hide
          Jakob Korherr added a comment -

          thx, Imre. I'll take a look at it soon!

          Show
          Jakob Korherr added a comment - thx, Imre. I'll take a look at it soon!
          Hide
          Imre Osswald added a comment - - edited

          Hi Jakob,
          Thank you!

          I will also check if I can make mojarra accept that no BV-Impl has to be available even if a BV-Api is present.
          I think that would be the preferred resolution of this issue.

          (The addition of a commented section, would still be something to consider)

          Show
          Imre Osswald added a comment - - edited Hi Jakob, Thank you! I will also check if I can make mojarra accept that no BV-Impl has to be available even if a BV-Api is present. I think that would be the preferred resolution of this issue. (The addition of a commented section, would still be something to consider)
          Hide
          Imre Osswald added a comment -

          Hi Jakob,

          Gerhard has identified this as an issue in mojarra (see http://java.net/jira/browse/JAVASERVERFACES-2061).
          I have a working fix ready for mojarra, so I guess we should resolve this issue as invalid/won't fix.

          Show
          Imre Osswald added a comment - Hi Jakob, Gerhard has identified this as an issue in mojarra (see http://java.net/jira/browse/JAVASERVERFACES-2061 ). I have a working fix ready for mojarra, so I guess we should resolve this issue as invalid/won't fix.
          Hide
          Gerhard Petracek added a comment -

          thx imre for fixing mojarra. however, we can add bv in any case.

          Show
          Gerhard Petracek added a comment - thx imre for fixing mojarra. however, we can add bv in any case.
          Hide
          Jakob Korherr added a comment -

          Thanks for taking care of this, guys.

          Actually my first thought was that Mojarra may do a wrong bval availability check, so that's great.

          > however, we can add bv in any case.
          I am not a fan of this. The archetype should be as simple as possible. However, we could provide a bval archetype or a config property to enable it when the archetype is generated, but not by default!

          Show
          Jakob Korherr added a comment - Thanks for taking care of this, guys. Actually my first thought was that Mojarra may do a wrong bval availability check, so that's great. > however, we can add bv in any case. I am not a fan of this. The archetype should be as simple as possible. However, we could provide a bval archetype or a config property to enable it when the archetype is generated, but not by default!
          Hide
          Imre Osswald added a comment -

          I agree with Jakob on not including it by default.
          Maybe the best solution would be to have a wiki about the different archetypes (maybe that one already exists?) and add a comment there and include a link to it in the pom.

          Once the fix is gone into the maven-repo I'll notice Gerhard on IRC, to up the version. (Not sure how long this will take, this minor change alone will probably not be worth a new "promoted" build)

          Show
          Imre Osswald added a comment - I agree with Jakob on not including it by default. Maybe the best solution would be to have a wiki about the different archetypes (maybe that one already exists?) and add a comment there and include a link to it in the pom. Once the fix is gone into the maven-repo I'll notice Gerhard on IRC, to up the version. (Not sure how long this will take, this minor change alone will probably not be worth a new "promoted" build)
          Hide
          Jakob Korherr added a comment -

          I think there is no wiki, but a maven site: see http://myfaces.apache.org/build-tools/archetypes/

          > Not sure how long this will take, this minor change alone will probably not be worth a new "promoted" build
          Hehe, I guess not

          Show
          Jakob Korherr added a comment - I think there is no wiki, but a maven site: see http://myfaces.apache.org/build-tools/archetypes/ > Not sure how long this will take, this minor change alone will probably not be worth a new "promoted" build Hehe, I guess not

            People

            • Assignee:
              Jakob Korherr
              Reporter:
              Imre Osswald
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development