Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: Server
    • Labels:
      None

      Description

      I think it's time to carefully consider issues related to possible upgrade to Lift 2.3 version. RC1 has been already released. Right now it implies only minor change in code: due to JsExp is no longer subclass of scala.xml.SpecialNode, implicit converson from Long to JsExp is not applicable for scala.xml.UnprefixedAttribute in Mailbox.scala. For more info see: http://groups.google.com/group/liftweb/browse_thread/thread/602de79127070b90 . It's easy to fix with toString call. More serious change relates to Extended Session (it is used to set a cookie and store userId into DB for subsequent automatic login). Currently used technique to bind Extended Session via S.addAround() call is not valid anymore and fails at runtime, see: http://groups.google.com/group/liftweb/browse_thread/thread/fa773ef9a5db50ca . It's neccessary to wait until new mechanism: LiftRules.earlyInStateful is introduced.

      1. upgrade.patch
        3 kB
        Vladimir Ivanov

        Activity

        Hide
        Dick Hirsch added a comment -

        I was also thinking about switching to 2.3.

        Should we migrate if the Extended Session problem still exists? Does your patch solve the problem?

        Show
        Dick Hirsch added a comment - I was also thinking about switching to 2.3. Should we migrate if the Extended Session problem still exists? Does your patch solve the problem?
        Hide
        Vladimir Ivanov added a comment - - edited

        No, we shouldn't - problem with Extended Session hasn't been solved yet . I've included patch only show fix for compilation issue in Mailbox.scala. When new API for Extended Session will be available I will try to update patch accordingly.

        I've added this issue to track changes related to Lift 2.3.

        Show
        Vladimir Ivanov added a comment - - edited No, we shouldn't - problem with Extended Session hasn't been solved yet . I've included patch only show fix for compilation issue in Mailbox.scala. When new API for Extended Session will be available I will try to update patch accordingly. I've added this issue to track changes related to Lift 2.3.
        Hide
        Vladimir Ivanov added a comment -

        New API for Extended Session will be included in Lift 2.3-RC2: http://groups.google.com/group/liftweb/browse_thread/thread/d3a0a54fe53a40d2

        Show
        Vladimir Ivanov added a comment - New API for Extended Session will be included in Lift 2.3-RC2: http://groups.google.com/group/liftweb/browse_thread/thread/d3a0a54fe53a40d2
        Hide
        Vladimir Ivanov added a comment - - edited

        Updated to Lift 2.3 RC3. New API for Extended Session was used in modified patch.

        Show
        Vladimir Ivanov added a comment - - edited Updated to Lift 2.3 RC3. New API for Extended Session was used in modified patch.
        Hide
        Ethan Jewett added a comment -

        I've got this applied and it looks like it is working, but due to the Jetty problem I emailed the list about I cannot test it.

        Show
        Ethan Jewett added a comment - I've got this applied and it looks like it is working, but due to the Jetty problem I emailed the list about I cannot test it.
        Hide
        Dick Hirsch added a comment -

        Should I apply this patch or wait until Ethan has tested?

        Show
        Dick Hirsch added a comment - Should I apply this patch or wait until Ethan has tested?
        Hide
        Ethan Jewett added a comment -

        Dick, if you can get the tests to pass, go for it

        Show
        Ethan Jewett added a comment - Dick, if you can get the tests to pass, go for it
        Hide
        Vladimir Ivanov added a comment -

        Shouldn't we wait until Lift 2.3 version is released?

        Show
        Vladimir Ivanov added a comment - Shouldn't we wait until Lift 2.3 version is released?
        Hide
        Dick Hirsch added a comment -

        If I remember correctly, RC3 is due to be released in April. We could wait. Is there any functionality that we absolutely need now?

        Show
        Dick Hirsch added a comment - If I remember correctly, RC3 is due to be released in April. We could wait. Is there any functionality that we absolutely need now?
        Hide
        Vladimir Ivanov added a comment -

        As far as I know, there is no such functionality.

        Show
        Vladimir Ivanov added a comment - As far as I know, there is no such functionality.
        Hide
        Hudson added a comment -

        Integrated in ESME #554 (See https://hudson.apache.org/hudson/job/ESME/554/)
        Completed ESME-341: Upgrade to Lift 2.3 version.

        Show
        Hudson added a comment - Integrated in ESME #554 (See https://hudson.apache.org/hudson/job/ESME/554/ ) Completed ESME-341 : Upgrade to Lift 2.3 version.

          People

          • Assignee:
            Vladimir Ivanov
            Reporter:
            Vladimir Ivanov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development