Enterprise Social Messaging Environment (ESME)
  1. Enterprise Social Messaging Environment (ESME)
  2. ESME-336

Streams shows all pools rather than the pools in which I'm a member

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: Server
    • Labels:

      Description

      On the Streams page I see all pools rather than just the pools in which I'm a member

      1. ASF.LICENSE.NOT.GRANTED--Groups for User A.jpg
        82 kB
        Dick Hirsch
      2. ASF.LICENSE.NOT.GRANTED--Pools from user B.jpg
        61 kB
        Dick Hirsch
      3. pools.patch
        2 kB
        Vladimir Ivanov

        Activity

        Hide
        Ethan Jewett added a comment -

        I don't quite understand what this means. Can you seem messages from pools you are not a member of? If so, this is a huge blocker for release 1.2. However, I can't recreate this behavior, so I wonder if you mean something else?

        Show
        Ethan Jewett added a comment - I don't quite understand what this means. Can you seem messages from pools you are not a member of? If so, this is a huge blocker for release 1.2. However, I can't recreate this behavior, so I wonder if you mean something else?
        Hide
        Ethan Jewett added a comment -

        Oh, I see. You must be talking about the selection drop-down. That actually, amusingly, shows all pools in which you aren't a member, unless I'm mistaken. Clearly we have an inverted boolean test somewhere that needs to be fixed.

        Show
        Ethan Jewett added a comment - Oh, I see. You must be talking about the selection drop-down. That actually, amusingly, shows all pools in which you aren't a member, unless I'm mistaken. Clearly we have an inverted boolean test somewhere that needs to be fixed.
        Hide
        Vladimir Ivanov added a comment -

        I discover strange behavior - it makes impression that this drop-down is populated only once after application has been started. When I login as user1 it's populated correctly (for this user). But if I subsequently login as user2 (in different browser) I see all pools that belong to user1. If after that I restart app and login as user2, pools in drop-down are displayed correctly (for user2), and, in turn, incorrectly for user1. Could someone confirm this behaviour?

        Show
        Vladimir Ivanov added a comment - I discover strange behavior - it makes impression that this drop-down is populated only once after application has been started. When I login as user1 it's populated correctly (for this user). But if I subsequently login as user2 (in different browser) I see all pools that belong to user1. If after that I restart app and login as user2, pools in drop-down are displayed correctly (for user2), and, in turn, incorrectly for user1. Could someone confirm this behaviour?
        Hide
        Vladimir Ivanov added a comment -

        Correct me if I'm wrong, but it seems to me that 'pools' val in StreamDisplay object is initialized only once as it should be for singleton object. So it's clear that pools drop-down is populated only once with values that are actual only for first logged in user. Probably it's better to define pools as a RequestVar. I suppose that it's equally applicable for 'following' val in the same object.

        Show
        Vladimir Ivanov added a comment - Correct me if I'm wrong, but it seems to me that 'pools' val in StreamDisplay object is initialized only once as it should be for singleton object. So it's clear that pools drop-down is populated only once with values that are actual only for first logged in user. Probably it's better to define pools as a RequestVar. I suppose that it's equally applicable for 'following' val in the same object.
        Hide
        Vladimir Ivanov added a comment -

        I've attached patch to fix "initialize-only-once" issue. Now it's neccessary to check that drop-down includes only those pools in which user is a member.

        Show
        Vladimir Ivanov added a comment - I've attached patch to fix "initialize-only-once" issue. Now it's neccessary to check that drop-down includes only those pools in which user is a member.
        Hide
        Ethan Jewett added a comment -

        Vladimir, did your patch get applied? If not, let's leave the issue open so we don't forget about it. My apologies for not getting to it sooner, but it's been a busy week. I'm hoping to apply it either later tonight or (more likely) Sunday.

        Show
        Ethan Jewett added a comment - Vladimir, did your patch get applied? If not, let's leave the issue open so we don't forget about it. My apologies for not getting to it sooner, but it's been a busy week. I'm hoping to apply it either later tonight or (more likely) Sunday.
        Hide
        Vladimir Ivanov added a comment -

        No, it hasn't. No problem, I understand - I read about your business trip ;s) . You are right it's easy to forget apply them. I'll then reopen issues with patches attached.

        Show
        Vladimir Ivanov added a comment - No, it hasn't. No problem, I understand - I read about your business trip ;s) . You are right it's easy to forget apply them. I'll then reopen issues with patches attached.
        Hide
        Vladimir Ivanov added a comment - - edited

        It's better to retain this issue in 'Open' status until patch is applied.

        Show
        Vladimir Ivanov added a comment - - edited It's better to retain this issue in 'Open' status until patch is applied.
        Hide
        Dick Hirsch added a comment -

        Tested patch on Stax - works great - committed

        Show
        Dick Hirsch added a comment - Tested patch on Stax - works great - committed
        Hide
        Dick Hirsch added a comment -

        Tested on stax

        Show
        Dick Hirsch added a comment - Tested on stax

          People

          • Assignee:
            Vladimir Ivanov
            Reporter:
            Dick Hirsch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development