Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: Server
    • Labels:
      None

      Description

      Compiler issues multiple warnings related to usage of methods that have been deprecated in Lift 2.2 and Scala 2.8.1. Very likely these methods will be removed in future Lift and Scala versions, so it would be better to use new methods instead.

      1. depr.diff
        18 kB
        Vladimir Ivanov

        Activity

        Hide
        Hudson added a comment -

        Integrated in ESME #592 (See https://builds.apache.org/hudson/job/ESME/592/)
        ESME-321 Removed superfluous methods from FetchFeed
        ESME-321 Remove explicit MergeableEither instantiation since it's done implicitly

        Show
        Hudson added a comment - Integrated in ESME #592 (See https://builds.apache.org/hudson/job/ESME/592/ ) ESME-321 Removed superfluous methods from FetchFeed ESME-321 Remove explicit MergeableEither instantiation since it's done implicitly
        Hide
        Hudson added a comment -

        Integrated in ESME #586 (See https://builds.apache.org/hudson/job/ESME/586/)
        Finished with ESME-321: Get rid of deprecated methods

        Show
        Hudson added a comment - Integrated in ESME #586 (See https://builds.apache.org/hudson/job/ESME/586/ ) Finished with ESME-321 : Get rid of deprecated methods
        Hide
        Vladimir Ivanov added a comment -

        Finished with remaining deprecation warnings

        Show
        Vladimir Ivanov added a comment - Finished with remaining deprecation warnings
        Hide
        Ethan Jewett added a comment -

        Moving to 1.3 - This has mostly been addressed but there are a couple dangling issues. Since it does not affect end-user experience it is not a release stopper.

        Show
        Ethan Jewett added a comment - Moving to 1.3 - This has mostly been addressed but there are a couple dangling issues. Since it does not affect end-user experience it is not a release stopper.
        Hide
        Hudson added a comment -

        Integrated in ESME #495 (See https://hudson.apache.org/hudson/job/ESME/495/)
        ESME-321 Fixes Log deprecation warnings by moving to the Loggable mixin trait, and fixes .first deprecation warnings in the API2Test.scala code

        Show
        Hudson added a comment - Integrated in ESME #495 (See https://hudson.apache.org/hudson/job/ESME/495/ ) ESME-321 Fixes Log deprecation warnings by moving to the Loggable mixin trait, and fixes .first deprecation warnings in the API2Test.scala code
        Hide
        Vassil Dichev added a comment -

        1) is OK, the test was incorrect- I have assumed that a stable sort is used, which is obviously a dangerous assumption to make.
        2) This seems OK, but Either is not used correctly in TwitterAPI anyway, so it has to go (let's leave this for long-term)
        3+4) Must take some more time to research

        Show
        Vassil Dichev added a comment - 1) is OK, the test was incorrect- I have assumed that a stable sort is used, which is obviously a dangerous assumption to make. 2) This seems OK, but Either is not used correctly in TwitterAPI anyway, so it has to go (let's leave this for long-term) 3+4) Must take some more time to research
        Hide
        Vladimir Ivanov added a comment -

        I've added first version of patch related to getting rid of deprecation warnings. I have some questions regarding remaining deprecated methods:

        1) Method List.sort() is deprecated and Scala compiler suggests to use SeqLike.sortWith() instead. I replaced this method by new version in PopStatsActor:95. Now corresponding test spec PopStatsActorSpecs is failing with two errors:

        [error] x Popularity Stats should
        [error] x Update top hits after inrcementing statistics
        [error] 'List((1,1), (3,1))' is not equal to 'List((3,1), (1,1))' (PopStatsActorTest.scala:44)
        [error] x Information should expire after timeout
        [error] 'List((3,1))' is not equal to 'List()' (PopStatsActorTest.scala:54)

        Other tests passed.

        2) Method Either.merge() used in TwitterAPI: 390 is deprecated. I suppose that this method will be replaced by MergeableEither.merge() via implicit either2mergeable() conversion method. Please correct me if I'm wrong.
        3) We have case class FetchFeed with two subclasses FetchAtom and FetchRss. Scala compiler calls it unduly implementation and suggests using Extractor object instead, but I don't know whether it is simpler solution...
        4) Object Log is deprecated in Lift 2.2. How do you think if it's correct to mixin with Loggable trait and use default logger val?

        Show
        Vladimir Ivanov added a comment - I've added first version of patch related to getting rid of deprecation warnings. I have some questions regarding remaining deprecated methods: 1) Method List.sort() is deprecated and Scala compiler suggests to use SeqLike.sortWith() instead. I replaced this method by new version in PopStatsActor:95. Now corresponding test spec PopStatsActorSpecs is failing with two errors: [error] x Popularity Stats should [error] x Update top hits after inrcementing statistics [error] 'List((1,1), (3,1))' is not equal to 'List((3,1), (1,1))' (PopStatsActorTest.scala:44) [error] x Information should expire after timeout [error] 'List((3,1))' is not equal to 'List()' (PopStatsActorTest.scala:54) Other tests passed. 2) Method Either.merge() used in TwitterAPI: 390 is deprecated. I suppose that this method will be replaced by MergeableEither.merge() via implicit either2mergeable() conversion method. Please correct me if I'm wrong. 3) We have case class FetchFeed with two subclasses FetchAtom and FetchRss. Scala compiler calls it unduly implementation and suggests using Extractor object instead, but I don't know whether it is simpler solution... 4) Object Log is deprecated in Lift 2.2. How do you think if it's correct to mixin with Loggable trait and use default logger val?

          People

          • Assignee:
            Vladimir Ivanov
            Reporter:
            Vladimir Ivanov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development