Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: Server
    • Labels:
      None

      Description

      Look at lift wiki for details

        Activity

        Hide
        Dick Hirsch added a comment -

        http://www.assembla.com/wiki/show/liftweb/logchanger

        object LoglevelChanger extends LoglevelChanger with LogbackContext

        { override def menuLocParams: List[Loc.AnyLocParam] = if (Props.productionMode) List(User.testSuperUser) else Nil }
        Show
        Dick Hirsch added a comment - http://www.assembla.com/wiki/show/liftweb/logchanger object LoglevelChanger extends LoglevelChanger with LogbackContext { override def menuLocParams: List[Loc.AnyLocParam] = if (Props.productionMode) List(User.testSuperUser) else Nil }
        Hide
        Dick Hirsch added a comment -

        This is actually an easy item to fix - I'd like to use "User.checkRole("integration-admin")" instead of List(User.testSuperUser)

        but I get some exceptions

        [INFO] Compiling 1 source files to D:\apache\esme\trunk\server\target\classes
        [WARNING] D:\apache\esme\trunk\server\src\main\scala\bootstrap\liftweb\Boot.scal
        a:125: error: not found: type LoglevelChanger
        [WARNING] object LoglevelChanger extends LoglevelChanger with LogbackContext
        {
        [WARNING] ^
        [WARNING] D:\apache\esme\trunk\server\src\main\scala\bootstrap\liftweb\Boot.scal
        a:125: error: not found: type LogbackContext
        [WARNING] object LoglevelChanger extends LoglevelChanger with LogbackContext
        {
        [WARNING] ^
        [WARNING] D:\apache\esme\trunk\server\src\main\scala\bootstrap\liftweb\Boot.scal
        a:126: error: type mismatch;
        [WARNING] found : Boolean
        [WARNING] required: net.liftweb.sitemap.Loc.AnyLocParam
        [WARNING] override def menuLocParams: List[Loc.AnyLocParam] = if (Props.pr
        oductionMode) List(User.checkRole("integration-admin")) else Nil
        [WARNING]
        ^
        [WARNING] three errors found

        Show
        Dick Hirsch added a comment - This is actually an easy item to fix - I'd like to use "User.checkRole("integration-admin")" instead of List(User.testSuperUser) but I get some exceptions [INFO] Compiling 1 source files to D:\apache\esme\trunk\server\target\classes [WARNING] D:\apache\esme\trunk\server\src\main\scala\bootstrap\liftweb\Boot.scal a:125: error: not found: type LoglevelChanger [WARNING] object LoglevelChanger extends LoglevelChanger with LogbackContext { [WARNING] ^ [WARNING] D:\apache\esme\trunk\server\src\main\scala\bootstrap\liftweb\Boot.scal a:125: error: not found: type LogbackContext [WARNING] object LoglevelChanger extends LoglevelChanger with LogbackContext { [WARNING] ^ [WARNING] D:\apache\esme\trunk\server\src\main\scala\bootstrap\liftweb\Boot.scal a:126: error: type mismatch; [WARNING] found : Boolean [WARNING] required: net.liftweb.sitemap.Loc.AnyLocParam [WARNING] override def menuLocParams: List [Loc.AnyLocParam] = if (Props.pr oductionMode) List(User.checkRole("integration-admin")) else Nil [WARNING] ^ [WARNING] three errors found
        Hide
        Ethan Jewett added a comment -

        Just a quick comment on the role - I think we should use another role, not 'integration-admin'. The 'integration-admin' role is narrowly focused at API users to enable integration scenarios. I think log access is an entirely different type of administration.

        Show
        Ethan Jewett added a comment - Just a quick comment on the role - I think we should use another role, not 'integration-admin'. The 'integration-admin' role is narrowly focused at API users to enable integration scenarios. I think log access is an entirely different type of administration.
        Hide
        Dick Hirsch added a comment -

        OK - instead of "integration-admin" we could use "monitoring-admin"

        Unfortunately, the Scala errors remain

        Show
        Dick Hirsch added a comment - OK - instead of "integration-admin" we could use "monitoring-admin" Unfortunately, the Scala errors remain
        Hide
        Dick Hirsch added a comment -

        OK - how would the Scala code look like.? Like this?

        override def menuLocParams: List[Loc.AnyLocParam] = if (Props.productionMode) List(User.checkRole("monitoring-admin")) else Nil

        Show
        Dick Hirsch added a comment - OK - how would the Scala code look like.? Like this? override def menuLocParams: List [Loc.AnyLocParam] = if (Props.productionMode) List(User.checkRole("monitoring-admin")) else Nil
        Hide
        Dick Hirsch added a comment -

        Vladimir checked it locally with an LDAP hooked up

        Show
        Dick Hirsch added a comment - Vladimir checked it locally with an LDAP hooked up
        Hide
        Hudson added a comment -

        Integrated in ESME #587 (See https://builds.apache.org/hudson/job/ESME/587/)
        In scope of ESME-233: Changed 'notProdOrHasAdminRights' LocParam to be lazily initialized.
        ESME-233 Restrict access to the logchanger in production mode

        Show
        Hudson added a comment - Integrated in ESME #587 (See https://builds.apache.org/hudson/job/ESME/587/ ) In scope of ESME-233 : Changed 'notProdOrHasAdminRights' LocParam to be lazily initialized. ESME-233 Restrict access to the logchanger in production mode

          People

          • Assignee:
            Unassigned
            Reporter:
            Dick Hirsch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development