[EMPIREDB-216] reserved words as colum names not correctly escaped/quoted for derby

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: empire-db-2.4.3
• Fix Version/s: empire-db-2.4.4
• Assignee: Rainer Döbele
• Reporter: Harald Kirsch
• Created: 14/Nov/14 13:31
• Updated: 19/Nov/14 12:42
• Resolved: 19/Nov/14 12:42

Description

Created from getCreateDDLScript() I get

CREATE TABLE DIM_date (
ID INT GENERATED ALWAYS AS IDENTITY NOT NULL,
...
year SMALLINT NOT NULL,
...
);

I get

2014-11-14T13:01:14Z ERROR org.apache.empire.db.DBSQLScript java.sql.SQLSyntaxErrorException: Syntax error: Encountered "year" at line 6, column 4.
java.sql.SQLSyntaxErrorException: Syntax error: Encountered "year" at line 6, column 4.
at org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source)

I think all column names in generated scripts should be enclosed in double quotes to shield against such misinterpretation.