[EMAIL-98] Encoding and folding of headers should not be left to the user

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3
• Assignee: Siegfried Goeschl
• Reporter: Mario Däpp
• Created: 27/Jul/10 08:09
• Updated: 11/Jan/13 15:47
• Resolved: 23/Oct/10 22:09

Description

Currently, folding and encoding of e-mail headers is completely left to the user. As commons-email is aimed at simplification of the Java Mail API, the encoding and folding issues should be taken care of by commons-email.

The method buildMimeMessage() in Email.java should be changed as follows:

if (this.headers.size() > 0)
{
Iterator iterHeaderKeys = this.headers.keySet().iterator();
while (iterHeaderKeys.hasNext())

{ String name = (String) iterHeaderKeys.next(); String value = (String) headers.get(name); this.message.addHeader(name, MimeUtility.fold(name.length() + 2, MimeUtility.encodeText(value, this.charset, null))); }

}