Commons Email
  1. Commons Email
  2. EMAIL-62

[email] Build patches to enforce source 1.4 and target 1.4 when compiling

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.1
    • Labels:
      None

      Description

      Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.

      1. build.xml.patch
        1 kB
        Ben Speakmon
      2. project.properties
        3 kB
        Ben Speakmon
      3. project.properties.patch
        0.7 kB
        Ben Speakmon

        Activity

        Hide
        Ben Speakmon added a comment -

        Changing summary since I'm about to attach another patch to enforce 1.4 source/target in the Maven build...

        Show
        Ben Speakmon added a comment - Changing summary since I'm about to attach another patch to enforce 1.4 source/target in the Maven build...
        Hide
        Ben Speakmon added a comment -

        Oops. Maybe I'll attach the patch instead of the whole file.

        Show
        Ben Speakmon added a comment - Oops. Maybe I'll attach the patch instead of the whole file.
        Hide
        dion gillard added a comment -

        So this means that commons-email is now JDK 1.4+.

        Has anyone surveyed the users and seen if we still have any on 1.3 that can't stay on email 1.0?

        Show
        dion gillard added a comment - So this means that commons-email is now JDK 1.4+. Has anyone surveyed the users and seen if we still have any on 1.3 that can't stay on email 1.0?
        Hide
        Piero Ottuzzi added a comment -

        Hi Dion, all,

        commons-email 1.0 is quite broken and I think we need to move forward and release something working: the actual version has many problems and holding on a release for a JDK1.3 compatibility it seems overkill to me.

        Just my idea...
        Bye
        Piero

        Show
        Piero Ottuzzi added a comment - Hi Dion, all, commons-email 1.0 is quite broken and I think we need to move forward and release something working: the actual version has many problems and holding on a release for a JDK1.3 compatibility it seems overkill to me. Just my idea... Bye Piero
        Hide
        Ben Speakmon added a comment -

        I'm with Dion 100% on meeting the needs of users, but as I said on the list, I consider the benefits of using 1.4 – allowing us to use the latest javamail/activation versions, much better charset support, etc. – outweigh the new dependencies. It's better than asking users to stick with the known bugs of javamail 1.3.1 and being forced to reimplement the charset code in 1.3 when the majority of people using it are on at least 1.4.

        It's not my project, though, and if 1.4 is unacceptable for some other reason, we'll think of something clever. As Piero says, the important thing is to get fixes out for what's not working.

        Show
        Ben Speakmon added a comment - I'm with Dion 100% on meeting the needs of users, but as I said on the list, I consider the benefits of using 1.4 – allowing us to use the latest javamail/activation versions, much better charset support, etc. – outweigh the new dependencies. It's better than asking users to stick with the known bugs of javamail 1.3.1 and being forced to reimplement the charset code in 1.3 when the majority of people using it are on at least 1.4. It's not my project, though, and if 1.4 is unacceptable for some other reason, we'll think of something clever. As Piero says, the important thing is to get fixes out for what's not working.
        Hide
        dion gillard added a comment -

        Does anyone know why we're patching a Maven-generated build.xml file instead of just regenerating it?

        Doesn't the maven ant plugin generate a build file with the correct javac task attributes?

        Show
        dion gillard added a comment - Does anyone know why we're patching a Maven-generated build.xml file instead of just regenerating it? Doesn't the maven ant plugin generate a build file with the correct javac task attributes?
        Hide
        Ben Speakmon added a comment -

        I didn't know how to generate a build.xml from maven at the time. I have no idea if it would work given a correct project (or pom).

        I have zero objection to regenerating it.

        Show
        Ben Speakmon added a comment - I didn't know how to generate a build.xml from maven at the time. I have no idea if it would work given a correct project (or pom). I have zero objection to regenerating it.
        Hide
        Henri Yandell added a comment -

        It doesn't seem to get included. I changed the project.properties to 1.4 target, and ran maven ant. There's no occurrence of 1.4 or maven.compile.source in the build.xml.

        Personally - I think the build.xml should be removed, it only has value when we were trying to build 1.3 specific builds.

        Show
        Henri Yandell added a comment - It doesn't seem to get included. I changed the project.properties to 1.4 target, and ran maven ant. There's no occurrence of 1.4 or maven.compile.source in the build.xml. Personally - I think the build.xml should be removed, it only has value when we were trying to build 1.3 specific builds.
        Hide
        dion gillard added a comment -

        Patches applied - thanks guys!

        Show
        dion gillard added a comment - Patches applied - thanks guys!

          People

          • Assignee:
            Unassigned
            Reporter:
            Ben Speakmon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development