Commons Email
  1. Commons Email
  2. EMAIL-52

[email] Identical Inline images should share same BodyPart

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: Other

      Description

      If you have an HTML email with "spacer.gif" repeated several times, then you get
      that image included several times in the payload of the email. An optimization
      would be to "share" the sid across the several references.

      I have adapted HTMLEmail for my own purposes, and one of the "fixes" I have
      added is just such an optimization.

      Please could a Committer register their interest in this, and I will make a
      patch and submit for your consideration.

        Issue Links

          Activity

          Hide
          dion gillard added a comment -

          Fixed in EMAIL-50

          Show
          dion gillard added a comment - Fixed in EMAIL-50
          Hide
          Ben Speakmon added a comment -

          I've submitted a new patch to EMAIL-50 that fixes this issue.

          Show
          Ben Speakmon added a comment - I've submitted a new patch to EMAIL-50 that fixes this issue.
          Hide
          Ben Speakmon added a comment -

          Linking to the referenced issue.

          Show
          Ben Speakmon added a comment - Linking to the referenced issue.
          Hide
          Andrew Liles added a comment -

          In a related issue, COM-2523, I have provided an re-implementation of HtmlEmail
          as a separate class HtmlEmail2 which is attached to that bug report.

          Within that class is my implementation of a fix to this issue.

          That code is cannot be patched directly against HtmlEmail, but I could provide a
          patch if there is interest in my doing so.

          Show
          Andrew Liles added a comment - In a related issue, COM-2523 , I have provided an re-implementation of HtmlEmail as a separate class HtmlEmail2 which is attached to that bug report. Within that class is my implementation of a fix to this issue. That code is cannot be patched directly against HtmlEmail, but I could provide a patch if there is interest in my doing so.

            People

            • Assignee:
              Unassigned
              Reporter:
              Andrew Liles
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development