[EMAIL-35] [email] Embedding raw DataSource Attachments

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.1

Environment

Operating System: All
Platform: All

• Bugzilla Id: 36844
• Assignee: Ben Speakmon
• Reporter: Brandon Wolfe
• Created: 28/Sep/05 23:07
• Updated: 09/Jun/07 23:48
• Resolved: 09/Jun/07 23:48

Description

I kick myself for not submitting this prior to 1.0. An important feature
missing from org.apache.commons.mail.HtmlEmail is the ability to embed an
arbitrary DataSource object. The current API only allows you to embed from a
URL. My usage of CommonsEmail often includes the generation of image data
on-the-fly, where it does not exist at a pre-defined URL.

I propose the addition of a key method:

public String embed(DataSource datasource, String name, String cid) throws
EmailException

This will allow us to attach our own datasources in addition to defining our own
content-ids. Helper methods can be created to auto-generate CIDs when needed
and allow for backwards compatability. I've found that being able to provide my
own defined CIDs has been very helpful in referencing them in my velocity email
templates.

I will attach the current EnhancedHtmlEmail class that I have been using for a
year or so. It extends HtmlEmail to provide the methods explained above. I
would hope to have this capability introduced into the HtmlEmail class.

Feel free to contact me to discuss further! Thanks.

Issue Links

• is duplicated by: EMAIL-22 [email] New embed method for HtmlEmail