Commons Email
  1. Commons Email
  2. EMAIL-10

[email][PATCH] Resolve checkstyle errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: All

      Description

      This patch includes trivial changes to clean up the Checkstyle reports of
      Commons Email. Changes include modifying or adding missing javadoc, cleaning
      indentation, curly braces, parenthesis, and removing tabs and trailing spaces at
      the end of lines.

      After applying this patch, Email.java contains two Checkstyle errors because of
      its use of Hashtable's instead of Maps's. The 8 remaining errors indicate that
      each file does not end with a newline, which they do. I assume this is an error
      with the Maven-Checkstyle plugin.

      Thanks,
      Eric Spiegelberg

      1. ASF.LICENSE.NOT.GRANTED--big_checkstyle.patch
        252 kB
        Ramiro Pereira de Magalhaes
      2. ASF.LICENSE.NOT.GRANTED--checkstyle_clean_up.patch
        28 kB
        Eric Spiegelberg

        Activity

        Hide
        dion gillard added a comment -

        Applied the first patch.
        The second seems to change the style of the code.

        Show
        dion gillard added a comment - Applied the first patch. The second seems to change the style of the code.
        Hide
        Ramiro Pereira de Magalhaes added a comment -

        Created an attachment (id=15383)
        Cleans thousands of checkstyle errors

        I patched the Email revision 190136 with patch "15030: Cleans up Checkstyle
        errors" and also replaced tabs with 4 spaces, added "." at comments phrases,
        removed many traling spaces and did a few other Checkstyle fixes.

        Show
        Ramiro Pereira de Magalhaes added a comment - Created an attachment (id=15383) Cleans thousands of checkstyle errors I patched the Email revision 190136 with patch "15030: Cleans up Checkstyle errors" and also replaced tabs with 4 spaces, added "." at comments phrases, removed many traling spaces and did a few other Checkstyle fixes.
        Hide
        Eric Spiegelberg added a comment -

        Created an attachment (id=15030)
        Cleans up Checkstyle errors

        Show
        Eric Spiegelberg added a comment - Created an attachment (id=15030) Cleans up Checkstyle errors

          People

          • Assignee:
            Unassigned
            Reporter:
            Eric Spiegelberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development