Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: v0.6.0
    • Component/s: None
    • Labels:
      None

      Description

      hbase 0.98.4 release is very old.

      There wouldn't be any new 0.98 release.

      We should upgrade to 1.2.5 which is the latest stable release.

        Issue Links

          Activity

          Hide
          jhsenjaliya Jayesh added a comment -

          Ted Yu, pls assign this to yourself, if you are actively working on this.
          btw, I am already running eagle on hbase 1.2.2

          Show
          jhsenjaliya Jayesh added a comment - Ted Yu , pls assign this to yourself, if you are actively working on this. btw, I am already running eagle on hbase 1.2.2
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tedyu opened a pull request:

          https://github.com/apache/eagle/pull/902

          EAGLE-985 Upgrade hbase dependency to 1.2.5

          Upgrade hbase dependency to 1.2.5

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tedyu/eagle master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/eagle/pull/902.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #902


          commit 9c18fbb82920e75d6b0319bc00e47db16b8b9efd
          Author: tedyu <yuzhihong@gmail.com>
          Date: 2017-04-03T22:49:21Z

          EAGLE-985 Upgrade hbase dependency to 1.2.5


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tedyu opened a pull request: https://github.com/apache/eagle/pull/902 EAGLE-985 Upgrade hbase dependency to 1.2.5 Upgrade hbase dependency to 1.2.5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/902.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #902 commit 9c18fbb82920e75d6b0319bc00e47db16b8b9efd Author: tedyu <yuzhihong@gmail.com> Date: 2017-04-03T22:49:21Z EAGLE-985 Upgrade hbase dependency to 1.2.5
          Hide
          yuzhihong@gmail.com Ted Yu added a comment - - edited

          Jayesh:
          Can you assign this to me ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - - edited Jayesh : Can you assign this to me ?
          Hide
          jhsenjaliya Jayesh added a comment -

          Ted Yu somehow it can not be assigned by me ( attaching screenshot of error), can you try yourself ?

          Show
          jhsenjaliya Jayesh added a comment - Ted Yu somehow it can not be assigned by me ( attaching screenshot of error), can you try yourself ?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Please add me as a contributor:
          yuzhihong@gmail.com

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Please add me as a contributor: yuzhihong@gmail.com
          Hide
          yonzhang2012 Edward Zhang added a comment -

          Added. Thanks Ted.

          Show
          yonzhang2012 Edward Zhang added a comment - Added. Thanks Ted.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Jayesh Edward Zhang:
          Can you take a look at the PR ?

          Tests passed.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Jayesh Edward Zhang : Can you take a look at the PR ? Tests passed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jhsenjaliya commented on the issue:

          https://github.com/apache/eagle/pull/902

          +1, LGTM, I will be testing this on my dev environment as well sometime tomorrow.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/902 +1, LGTM, I will be testing this on my dev environment as well sometime tomorrow.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user qingwen220 commented on the issue:

          https://github.com/apache/eagle/pull/902

          @jhsenjaliya @tedyu After this upgrade, does we still support HBase 0.98?

          Show
          githubbot ASF GitHub Bot added a comment - Github user qingwen220 commented on the issue: https://github.com/apache/eagle/pull/902 @jhsenjaliya @tedyu After this upgrade, does we still support HBase 0.98?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jhsenjaliya commented on the issue:

          https://github.com/apache/eagle/pull/902

          Hi @qingwen220 no, since there are some function signature changes here, I dont think it will be compatible. ( without those changes, it is compatible though) so the question really comes down to whether we want to support 0.98 till 0.5 release then this can be pushed to 0.6 when majority of the tech stack is going to change ( storm, kafka, etc..), comment?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/902 Hi @qingwen220 no, since there are some function signature changes here, I dont think it will be compatible. ( without those changes, it is compatible though) so the question really comes down to whether we want to support 0.98 till 0.5 release then this can be pushed to 0.6 when majority of the tech stack is going to change ( storm, kafka, etc..), comment?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user qingwen220 commented on the issue:

          https://github.com/apache/eagle/pull/902

          Yes. We expect after 0.5, Eagle can support Kafka 0.10 & storm 0.10.

          There is a concern. We have a coprocessor module in Eagle for HBase 0.98. I am not sure if we could support this function after upgrade

          Show
          githubbot ASF GitHub Bot added a comment - Github user qingwen220 commented on the issue: https://github.com/apache/eagle/pull/902 Yes. We expect after 0.5, Eagle can support Kafka 0.10 & storm 0.10. There is a concern. We have a coprocessor module in Eagle for HBase 0.98. I am not sure if we could support this function after upgrade
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wujinhu commented on the issue:

          https://github.com/apache/eagle/pull/902

          Should we have multiple version support for HBase(Storm/Kafka etc) so that users can still use old versions if they cannot switch to new version quickly?
          I think it will be better if we have some abstractions first instead of doing like this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user wujinhu commented on the issue: https://github.com/apache/eagle/pull/902 Should we have multiple version support for HBase(Storm/Kafka etc) so that users can still use old versions if they cannot switch to new version quickly? I think it will be better if we have some abstractions first instead of doing like this.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          I may not have bandwidth to implement multi-version support for various hbase releases.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - I may not have bandwidth to implement multi-version support for various hbase releases.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user r7raul1984 commented on the issue:

          https://github.com/apache/eagle/pull/902

          @wujinhu +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user r7raul1984 commented on the issue: https://github.com/apache/eagle/pull/902 @wujinhu +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user r7raul1984 commented on the issue:

          https://github.com/apache/eagle/pull/902

          In my opition ,we should do more test before upgrade to hbase 1.2.5 rather than just solve compile problem .

          Show
          githubbot ASF GitHub Bot added a comment - Github user r7raul1984 commented on the issue: https://github.com/apache/eagle/pull/902 In my opition ,we should do more test before upgrade to hbase 1.2.5 rather than just solve compile problem .
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jhsenjaliya commented on the issue:

          https://github.com/apache/eagle/pull/902

          master works fine with hbase 1.2.2
          I am planning to test this patch with hbase 1.2.5 tonight

          Show
          githubbot ASF GitHub Bot added a comment - Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/902 master works fine with hbase 1.2.2 I am planning to test this patch with hbase 1.2.5 tonight
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user baibaichen commented on the issue:

          https://github.com/apache/eagle/pull/902

          hi @tedyu

          Is the new API you used supported in 1.0.x?

          Show
          githubbot ASF GitHub Bot added a comment - Github user baibaichen commented on the issue: https://github.com/apache/eagle/pull/902 hi @tedyu Is the new API you used supported in 1.0.x?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tedyu commented on the issue:

          https://github.com/apache/eagle/pull/902

          Yes. But hbase 1.0 wouldn't have any more new release.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tedyu commented on the issue: https://github.com/apache/eagle/pull/902 Yes. But hbase 1.0 wouldn't have any more new release.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tedyu commented on the issue:

          https://github.com/apache/eagle/pull/902

          @jhsenjaliya
          Did you find any issue during testing ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user tedyu commented on the issue: https://github.com/apache/eagle/pull/902 @jhsenjaliya Did you find any issue during testing ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jhsenjaliya commented on the issue:

          https://github.com/apache/eagle/pull/902

          @tedyu I pulled your PR and used ur code to run my eagle, I am running alert engine app + hdfs audit log app and it successfully created the alert i was expecting. so this PR is working fine. but As i mentioned earlier, I was using hbase 1.2.2 and also tested hbase 1.2.5 without any code change to eagle and it was working fine as well. so probably these changes are not mandatory but good to follow newer hbase functions.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/902 @tedyu I pulled your PR and used ur code to run my eagle, I am running alert engine app + hdfs audit log app and it successfully created the alert i was expecting. so this PR is working fine. but As i mentioned earlier, I was using hbase 1.2.2 and also tested hbase 1.2.5 without any code change to eagle and it was working fine as well. so probably these changes are not mandatory but good to follow newer hbase functions.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jhsenjaliya commented on the issue:

          https://github.com/apache/eagle/pull/902

          @qingwen220 , @r7raul1984 looks like we can accommodate hbase 1.2.5 with or without this PR changes but I havent tested with hbase coprocessor enabled. so if someone can test current eagle code with hbase 1.2.5 with coprocessor enabled, we can make decision on whether we can include hbase upgrade in eagle 0.5 or later.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jhsenjaliya commented on the issue: https://github.com/apache/eagle/pull/902 @qingwen220 , @r7raul1984 looks like we can accommodate hbase 1.2.5 with or without this PR changes but I havent tested with hbase coprocessor enabled. so if someone can test current eagle code with hbase 1.2.5 with coprocessor enabled, we can make decision on whether we can include hbase upgrade in eagle 0.5 or later.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          hbase 1.3.1 has been released.

          We can upgrade to 1.3.1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - hbase 1.3.1 has been released. We can upgrade to 1.3.1
          Hide
          jhsenjaliya Jayesh added a comment -

          Ted Yu lets target this for 0.6, since looks like we wont have time to test this with coprocessor enabled.
          with 0.6 target we will have sometime to test this.

          Show
          jhsenjaliya Jayesh added a comment - Ted Yu lets target this for 0.6, since looks like we wont have time to test this with coprocessor enabled. with 0.6 target we will have sometime to test this.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment - - edited

          Targeting 0.6 release is fine.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - - edited Targeting 0.6 release is fine.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment - - edited

          Jayesh:
          Is 0.6 release coming soon?

          Thanks

          Show
          yuzhihong@gmail.com Ted Yu added a comment - - edited Jayesh : Is 0.6 release coming soon? Thanks
          Hide
          jhsenjaliya Jayesh added a comment -

          Hi
          Can u pls disable the periodic updates to this ticket?

          Thanks
          Jayesh

          Show
          jhsenjaliya Jayesh added a comment - Hi Can u pls disable the periodic updates to this ticket? Thanks Jayesh

            People

            • Assignee:
              tedyu Ted Yu
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development