[EAGLE-888] Application submitted to Storm is always shown as “HBaseAuditLogApp”

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: v0.5.0
• Component/s: Core::App Engine
• Assignee: Da Zhou
• Reporter: Da Zhou
• Created: 08/Feb/17 01:29
• Updated: 22/Feb/17 18:53
• Resolved: 22/Feb/17 18:53

Description

Issue:
Steps to reproduce:

• Started application from Eagle UI (eg: alert engine)
• Go to Storm UI, topology name is shown as "HBaseAuditLogApp"

Reason:
In the constructor function of class "ApplicationAction":

this.effectiveConfig = ConfigFactory.parseMap(executionConfig)
.withFallback(serverConfig)
.withFallback(ConfigFactory.parseMap(metadata.getContext()))

According to the java doc of withFallBack(theOther) :

Returns a new value computed by merging this value with another, with keys in this value "winning" over the other one.

As a result, "serverConfig" will win over "ConfigFactory.parseMap(metadata.getContext())" which means the default "ConfigString(appId="HBaseAuditApp")" and "ConfigString(siteId="testSite")" will win over the meta data of the user's topology.

Fix:
Change the order of "withFallBack" to:

this.effectiveConfig = ConfigFactory.parseMap(executionConfig)
.withFallback(ConfigFactory.parseMap(metadata.getContext()))
.withFallback(serverConfig)

Issue Links

• links to: GitHub Pull Request #796