[EAGLE-844] Potential NPE issue

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: v0.5.0
• Fix Version/s: v0.5.0
• Component/s: Core::Query Engine
• Assignee: wujinhu
• Reporter: JC
• Created: 19/Dec/16 00:32
• Updated: 29/Dec/16 04:36
• Resolved: 29/Dec/16 04:36

Description

The following file accessed on Dec 18 2016 (Github revision id: 8fe968cb7e340e2f21711b5a0f701e760cb91d59), eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java, seems to have a potential null pointer exception.

Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
            if (entityServiceMap != null || entityServiceMap.values() != null) {
                for (EntityDefinition entityDefinition : entityServiceMap.values()) {
                    createTable(entityDefinition);
                }
            }

if entityServiceMap is null, entityServiceMap.values() could have NPE.
I have no idea if entityServiceMap can be null. Having said that, at least it could be a code smell.

Issue Links

• links to: GitHub Pull Request #751