Uploaded image for project: 'Eagle'
  1. Eagle
  2. EAGLE-487

use guice module better in app framework

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Resolved
    • Affects Version/s: v0.5.0
    • Fix Version/s: v0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      There are multiple issues with using guice module in app framework.

      1. ApplicationProviderServiceImpl is instantiated twice

      2. the interface between application and eagle server is not clear. It is not correct to only let application to register submodules,, instead it should includes some state inherited from eagle server, for example metadata storage type.

      3. not necessary to use module scope, it is pretty over-engineering when application only want to register some module.

      4. MemoryMetadataStore should use singleton

        Attachments

          Activity

            People

            • Assignee:
              yonzhang2012 Edward Zhang
              Reporter:
              yonzhang2012 Edward Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: