Uploaded image for project: 'Eagle'
  1. Eagle
  2. EAGLE-196

eagle-topology.sh should have jar file path as parameter

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: v0.3.0
    • Fix Version/s: v0.4.0
    • Component/s: None
    • Labels:

      Description

      eagle-topology.sh today assume the jar provided as following
      jarName=$(ls $

      {EAGLE_HOME}

      /lib/topology/eagle-topology-*-assembly.jar)
      We probably need an extra parameter for jar file

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user qingwen220 opened a pull request:

        https://github.com/apache/incubator-eagle/pull/147

        EAGLE-196 eagle-topology.sh supports jar file path as parameter

        https://issues.apache.org/jira/browse/EAGLE-196

        Add optional parameter --jar in EAGLE-HOME/bin/eagle-topology.sh

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/qingwen220/incubator-eagle EAGLE-196

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-eagle/pull/147.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #147


        commit c9f0a7a65a63857a481a95a4ea0c2242ce8ffb4c
        Author: Zhao, Qingwen <qingwzhao@ebay.com>
        Date: 2016-04-13T10:06:35Z

        eagle-topology.sh supports jar file path as parameter


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user qingwen220 opened a pull request: https://github.com/apache/incubator-eagle/pull/147 EAGLE-196 eagle-topology.sh supports jar file path as parameter https://issues.apache.org/jira/browse/EAGLE-196 Add optional parameter --jar in EAGLE-HOME/bin/eagle-topology.sh You can merge this pull request into a Git repository by running: $ git pull https://github.com/qingwen220/incubator-eagle EAGLE-196 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/147.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #147 commit c9f0a7a65a63857a481a95a4ea0c2242ce8ffb4c Author: Zhao, Qingwen <qingwzhao@ebay.com> Date: 2016-04-13T10:06:35Z eagle-topology.sh supports jar file path as parameter
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user qingwen220 commented on the pull request:

        https://github.com/apache/incubator-eagle/pull/147#issuecomment-209361587

        Only update a script bin/eagle-topology.sh, please help to review it. Thanks

        Show
        githubbot ASF GitHub Bot added a comment - Github user qingwen220 commented on the pull request: https://github.com/apache/incubator-eagle/pull/147#issuecomment-209361587 Only update a script bin/eagle-topology.sh, please help to review it. Thanks
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user haoch commented on the pull request:

        https://github.com/apache/incubator-eagle/pull/147#issuecomment-209409142

        LGTM

        Show
        githubbot ASF GitHub Bot added a comment - Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/147#issuecomment-209409142 LGTM
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-eagle/pull/147

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/147

          People

          • Assignee:
            qingwzhao Zhao, Qingwen
            Reporter:
            yonzhang2012 Edward Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development