Droids
  1. Droids
  2. DROIDS-163

SimpleTaskQueueWithHistory addAll does not add the new tasks

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.2.0
    • Component/s: core
    • Labels:
      None

      Description

      The method addAll should add a list of new Tasks to the queue.
      It must be looked to already added tasks to prevent double parsing of files.
      But the method always returned false.

      1. DROIDS-163.patch
        2 kB
        Tobias Rübner
      2. DROIDS-163_2.patch
        3 kB
        Tobias Rübner

        Activity

        Hide
        Richard Frovarp added a comment -

        It took me a couple of minutes to realize why the existing code doesn't work and why your patch would. Would it perhaps make sense to leave the short circuiting or in there, but call this.add(e) first? Would that be more clear?

        Show
        Richard Frovarp added a comment - It took me a couple of minutes to realize why the existing code doesn't work and why your patch would. Would it perhaps make sense to leave the short circuiting or in there, but call this.add(e) first? Would that be more clear?
        Hide
        Tobias Rübner added a comment -

        Yes, that would be more more clear.
        I updated the patch and added some more tests.

        Show
        Tobias Rübner added a comment - Yes, that would be more more clear. I updated the patch and added some more tests.
        Hide
        Richard Frovarp added a comment -

        Thank you. I've applied the patch in r1211018.

        Show
        Richard Frovarp added a comment - Thank you. I've applied the patch in r1211018.
        Hide
        Richard Frovarp added a comment -

        Resolved

        Show
        Richard Frovarp added a comment - Resolved

          People

          • Assignee:
            Unassigned
            Reporter:
            Tobias Rübner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development