Droids
  1. Droids
  2. DROIDS-116

replacing common logging by slf4j-api

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0, 0.2.0
    • Component/s: core
    • Labels:
      None
    1. droids-116-v1.diff
      23 kB
      Bertil Chapuis

      Activity

      Hide
      Bertil Chapuis added a comment -

      It make more sense to have use slf4j since people who use droids may want to choose their logger.

      Show
      Bertil Chapuis added a comment - It make more sense to have use slf4j since people who use droids may want to choose their logger.
      Hide
      Ryan McKinley added a comment -

      +1

      Show
      Ryan McKinley added a comment - +1
      Hide
      Florent ANDRE added a comment -

      may you already know it, but there is http://www.slf4j.org/migrator.html that can easiest the change.

      Show
      Florent ANDRE added a comment - may you already know it, but there is http://www.slf4j.org/migrator.html that can easiest the change.
      Hide
      Eugen Paraschiv added a comment -

      +1

      Show
      Eugen Paraschiv added a comment - +1
      Hide
      Bertil Chapuis added a comment -

      I think it also may sense to remove the Loggable Helper class and to use the LoggerFactory in each class which requires a Logger.

      Show
      Bertil Chapuis added a comment - I think it also may sense to remove the Loggable Helper class and to use the LoggerFactory in each class which requires a Logger.
      Hide
      Bertil Chapuis added a comment -

      Previously someone mentioned the fact that the Logger object should be static. Since Droids is a library I think it make sense to keep a Logger instance by Object while it's not really memory efficient. http://wiki.apache.org/jakarta-commons/Logging/StaticLog

      Show
      Bertil Chapuis added a comment - Previously someone mentioned the fact that the Logger object should be static. Since Droids is a library I think it make sense to keep a Logger instance by Object while it's not really memory efficient. http://wiki.apache.org/jakarta-commons/Logging/StaticLog
      Hide
      Bertil Chapuis added a comment -

      Sets Slf4j as the default logger.
      Erases the Loggable class.

      Show
      Bertil Chapuis added a comment - Sets Slf4j as the default logger. Erases the Loggable class.
      Hide
      Bertil Chapuis added a comment -

      The patch has been updated and applied.

      Show
      Bertil Chapuis added a comment - The patch has been updated and applied.
      Hide
      Tobias Rübner added a comment -

      There are still some dependencies to commons-logging.
      e.g. droids-core -> httpclient

      Show
      Tobias Rübner added a comment - There are still some dependencies to commons-logging. e.g. droids-core -> httpclient
      Hide
      Tobias Rübner added a comment -

      added excludes for commons-logging and added logging wrapper jcl-over-slf4j.

      fixed with r1348877

      Show
      Tobias Rübner added a comment - added excludes for commons-logging and added logging wrapper jcl-over-slf4j. fixed with r1348877

        People

        • Assignee:
          Tobias Rübner
          Reporter:
          Bertil Chapuis
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development