Droids
  1. Droids
  2. DROIDS-111

Open the API of RegexURLFilter to other types of input

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.1.0
    • Component/s: core
    • Labels:
      None

      Description

      The only type of input RegexURLFilter accepts is the name of a file (setFile), which is very restrictive.
      I'm suggesting to introduce another input type in the API - the regex expression, which makes much more sense than just being able to specify the regex expressions in an external file.

      1. DROIDS-111_v1.patch
        2 kB
        Eugen Paraschiv

        Issue Links

          Activity

          Hide
          Richard Frovarp added a comment -

          Looks good to me.

          Show
          Richard Frovarp added a comment - Looks good to me.
          Hide
          Eugen Paraschiv added a comment -

          Good, so what's the next step to get this committed?
          Thanks.

          Show
          Eugen Paraschiv added a comment - Good, so what's the next step to get this committed? Thanks.
          Hide
          Otis Gospodnetic added a comment - - edited

          Tabs should be spaces. Maybe a unit test would be good to add.
          Patch applies cleanly, existing unit tests still pass, committed - thanks!

          Now could somebody with JIRA privileges mark this issue as Fixed, please?

          Show
          Otis Gospodnetic added a comment - - edited Tabs should be spaces. Maybe a unit test would be good to add. Patch applies cleanly, existing unit tests still pass, committed - thanks! Now could somebody with JIRA privileges mark this issue as Fixed, please?

            People

            • Assignee:
              Unassigned
              Reporter:
              Eugen Paraschiv
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development