Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0-milestone-1
    • Labels:
      None

      Description

      No repeated fields and late bind schema support yet.

        Activity

        Hide
        Jacques Nadeau added a comment -

        Good stuff! I've applied

        Applying the patch, I had a rew issues. I've corrected them and applied but wanted to let you know for future patches.

        • You should prepare the patch using git-format-patch so we can keep commit information.
        • In JSONRecordReaderTest you refer to the raw ValueVector type. We should try to always use parameterized declarations for generic types.
        • Applying to the tip of execwork and running mvn clean test results in four test failures:

        Tests in error:
        testChangedSchemaInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_2.json (No such file or directory)
        testSameSchemaInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_1.json (No such file or directory)
        testChangedSchemaInTwoBatches(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_2.json (No such file or directory)
        testNestedFieldInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_3.json (No such file or directory)

        It looks like you were running these things with an assumption around the working path (maybe coming from within an IDE?). I updated them to use classpath location so that they no longer fail.

        Show
        Jacques Nadeau added a comment - Good stuff! I've applied Applying the patch, I had a rew issues. I've corrected them and applied but wanted to let you know for future patches. You should prepare the patch using git-format-patch so we can keep commit information. In JSONRecordReaderTest you refer to the raw ValueVector type. We should try to always use parameterized declarations for generic types. Applying to the tip of execwork and running mvn clean test results in four test failures: Tests in error: testChangedSchemaInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_2.json (No such file or directory) testSameSchemaInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_1.json (No such file or directory) testChangedSchemaInTwoBatches(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_2.json (No such file or directory) testNestedFieldInSameBatch(org.apache.drill.exec.store.JSONRecordReaderTest): java.io.FileNotFoundException: exec/java-exec/src/test/resources/scan_json_test_3.json (No such file or directory) It looks like you were running these things with an assumption around the working path (maybe coming from within an IDE?). I updated them to use classpath location so that they no longer fail.

          People

          • Assignee:
            Timothy Chen
            Reporter:
            Timothy Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development