[DRILL-7467] Jdbc plugin enhancements and fixes

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: Storage - JDBC
• Labels: ready-to-commit
• Assignee: Arina Ielchiieva
• Reporter: Priyanka Bhoir
• Reviewer: Vova Vysotskyi
• Created: 05/Dec/19 14:37
• Updated: 16/Mar/20 16:13
• Resolved: 23/Jan/20 15:56

Description

This Jira incorporates several JDBC plugin enhancements and fixes:
1. Drill does not close DB connection when JDBC storage plugin is disabled:
JdbcStoragePlugin does not implement the 'close' method, leaving all connections open even after the plugin is disabled. This could be monitored through 'lsof' command. Restarting a JDBC plugin adds to existing connections and Drill restart is required to release all TCP connections.
2. Add disabled jdbc plugin template to the boostrap storage plugins.
3. Add new jdbc storage plugin configuration property sourceParameters which will allow setting data source parameters described in BasicDataSource Configuration Parameters. Parameters names with incorrect naming will be ignored during plugin configuration,
parameter value which are of incorrect data type or illegal will fail storage plugin to start up.
Example: of sourceParameters section in storage plugin configuration:

      "sourceParameters" : {
        "maxIdle" : 8,
        "cacheState": true,
        "validationQuery": "select * from information_schema.collations"
      },

4. Upgraded commons-dbcp2 version and added it to the dependency management section in common pom.xml.

NOTE
In DRILL-7639 BasicDataSource was replaced with Hikari, sourceParameters sections remains and allows to configure data source, Hikari related configuration properties should be used instead. List of Hikari properties: https://github.com/brettwooldridge/HikariCP.

Issue Links

• incorporates: DRILL-7459 Fetch size does not work on Postgres JDBC plugin
• incorporates: DRILL-6738 validationQuery option for JDBC storage plugin
• incorporates: DRILL-7466 Configurable number of connection in JDBC storage connection pool
• links to: GitHub Pull Request #1956