Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-6920

Fix TestClient.testBasics() yarn test failure

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.15.0
    • Fix Version/s: 1.15.0
    • Component/s: None
    • Labels:

      Description

      TestClient.testBasics() test checks error messages for the case of usage non-existent commands. But it contains block for help command which exists in yarn and supported by Drill (see CommandLineOptions.Command enum).

      This test shares the same TestContext instance for all the tests, but for some envs, TestContext.getOut() may return the result of the execution of previous block. So for some systems this test passes and for other may fail.

      The solution is to add TestContext.resetOutput() calls for every test block and remove block with help command since it contradicts test javadoc.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vvysotskyi Volodymyr Vysotskyi
                Reporter:
                vvysotskyi Volodymyr Vysotskyi
                Reviewer:
                Vitalii Diravka
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: