[DRILL-6888] Nested classes in HashAggTemplate break the plain Java for debugging codegen

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Component/s: Execution - Relational Operators
• Labels: ready-to-commit
• Assignee: Boaz Ben-Zvi
• Reporter: Boaz Ben-Zvi
• Reviewer: Timothy Farkas
• Created: 08/Dec/18 02:26
• Updated: 04/Jan/19 07:04
• Resolved: 04/Jan/19 07:04

Description

The prefer_plain_java compile option is useful for debugging of generated code.

  DRILL-6719 ("separate spilling logic for Hash Agg") introduced two nested classes into the HashAggTemplate class.  However those nested classes cause the prefer_plain_java compile option to fail when compiling the generated code, like:

Error: SYSTEM ERROR: CompileException: File '/tmp/janino5709636998794673307.java', Line 36, Column 35: No applicable constructor/method found for actual parameters "org.apache.drill.exec.test.generated.HashAggregatorGen11$HashAggSpilledPartition"; candidates are: "protected org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate$BatchHolder org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate.injectMembers(org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate$BatchHolder)"

The proposed fix: Move those nested classes outside HashAgTemplate.

Issue Links

• links to: GitHub Pull Request #1569