[DRILL-6513] Drill should only allow valid values when users set planner.memory.max_query_memory_per_node

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: Query Planning & Optimization
• Labels: ready-to-commit
• Assignee: Salim Achouche
• Reporter: Salim Achouche
• Reviewer: Timothy Farkas
• Created: 18/Jun/18 16:59
• Updated: 22/Jun/18 21:23
• Resolved: 22/Jun/18 21:23

Description

The "planner.memory.max_query_memory_per_node" configuration can be currently set to values higher than the Drillbit Direct Memory configuration. The goal of this Jira is to fail queries with such an erroneous configuration to avoid runtime OOM.

NOTE - The current semantic of the maximum query memory per node configuration is that the end user has computed valid values especially knowing the current Drill limitations. Such values have to account for Netty's overhead (memory pools), shared pools (e.g., network exchanges), and concurrent query execution. This Jira should not be used to also cover such use-cases. The Drill Resource Management feature has the means to automate query quotas and the associated validation. We should create another Jira requesting the enhanced validations contracts under the umbrella of the Resource Management feature.   

 

 

Issue Links

• links to: GitHub Pull Request #1329