[DRILL-6435] MappingSet is stateful, so it can't be shared between threads

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Labels: ready-to-commit
• Assignee: Vlad Rozov
• Reporter: Vlad Rozov
• Reviewer: Paul Rogers
• Created: 22/May/18 20:11
• Updated: 02/Oct/19 21:38
• Resolved: 25/May/18 00:55

Description

There are several instances where static MappingSet instances are used (for example NestedLoopJoinBatch and BaseSortWrapper). This causes instance reuse across threads when queries are executed concurrently. As MappingSet is a stateful class with visitor design pattern, such reuse causes invalid state.

Issue Links

• causes: DRILL-6416 Unit test TestTpchDistributedConcurrent.testConcurrentQueries fails with AssertionError
• is caused by: DRILL-5325 Implement sub-operator unit tests for managed external sort
• is caused by: DRILL-6094 Decimal data type enhancements
• links to: GitHub Pull Request #1286