[DRILL-6295] PartitionerDecorator may close partitioners while CustomRunnable are active during query cancellation

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Labels: ready-to-commit
• Assignee: Vlad Rozov
• Reporter: Vlad Rozov
• Reviewer: Parth Chandra
• Created: 28/Mar/18 16:38
• Updated: 18/Apr/18 18:27
• Resolved: 18/Apr/18 18:27

Description

During query cancellation, in case PartitionerDecorator.executeMethodLogic() is active (waiting on the latch), the wait will be interrupted and Futures cancelled, but there is no guarantee that all CustomRunnable terminate before returning from PartitionerDecorator.executeMethodLogic(). On exit, both income and outgoing batches are cleared, leading to clearing of underlying Vectors and DrillBufs. This eventually causes unallocated memory access and JVM crash as CustomRunnable may execute after income/outgoing batches are cleared.

Issue Links

• causes: DRILL-6252 Foreman node is going down when the non foreman node is stopped
• links to: GitHub Pull Request #1208