[DRILL-6125] PartitionSenderRootExec can leak memory because close method is not synchronized

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.14.0
• Labels: ready-to-commit
• Assignee: Timothy Farkas
• Reporter: Timothy Farkas
• Reviewer: Vlad Rozov
• Created: 31/Jan/18 00:38
• Updated: 09/Apr/18 22:27
• Resolved: 30/Mar/18 15:12

Description

PartitionSenderRootExec creates a PartitionerDecorator and saves it in the partitioner field. The creation of the partitioner happens in the createPartitioner method. This method get's called by the main fragment thread. The partitioner field is accessed by the fragment thread during normal execution but it can also be accessed by the receivingFragmentFinished method which is a callback executed by the event processor thread. Because multiple threads can access the partitioner field synchronization is done on creation and on when receivingFragmentFinished. However, the close method can also be called by the event processor thread, and the close method does not synchronize before accessing the partitioner field. Since synchronization is not done the event processor thread may have an old reference to the partitioner when a query cancellation is done. Since it has an old reference the current partitioner can may not be cleared and a memory leak may occur.

Issue Links

• is related to: DRILL-6132 HashPartitionSender leaks memory
• links to: GitHub Pull Request #1105