[DRILL-5922] Intermittent Memory Leaks in the ROOT allocator

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Labels: ready-to-commit
• Assignee: Timothy Farkas
• Reporter: Timothy Farkas
• Reviewer: Paul Rogers
• Created: 02/Nov/17 17:34
• Updated: 22/Mar/18 00:56
• Resolved: 12/Jan/18 18:24

Description

This issue was originall found by ben-zvi. I am able to consistently reproduce the error on my laptop by running the following unit test:

org.apache.drill.exec.DrillSeparatePlanningTest#testMultiMinorFragmentComplexQuery

java.lang.IllegalStateException: Allocator[ROOT] closed with outstanding child allocators.
Allocator(ROOT) 0/1048576/10113536/3221225472 (res/actual/peak/limit)
  child allocators: 1
    Allocator(query:26049b50-0cec-0a92-437c-bbe486e1fcbf) 1048576/0/0/268435456 (res/actual/peak/limit)
      child allocators: 0
      ledgers: 0
      reservations: 0
  ledgers: 0
  reservations: 0

	at org.apache.drill.exec.memory.BaseAllocator.close(BaseAllocator.java:496) ~[classes/:na]
	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:76) [classes/:na]
	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:64) [classes/:na]
	at org.apache.drill.exec.server.BootStrapContext.close(BootStrapContext.java:256) ~[classes/:na]
	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:76) [classes/:na]
	at org.apache.drill.common.AutoCloseables.close(AutoCloseables.java:64) [classes/:na]
	at org.apache.drill.exec.server.Drillbit.close(Drillbit.java:205) [classes/:na]
	at org.apache.drill.BaseTestQuery.closeClient(BaseTestQuery.java:315) [test-classes/:na]
	at org.apache.drill.BaseTestQuery.updateTestCluster(BaseTestQuery.java:157) [test-classes/:na]
	at org.apache.drill.BaseTestQuery.updateTestCluster(BaseTestQuery.java:148) [test-classes/:na]
	at org.apache.drill.exec.DrillSeparatePlanningTest.getFragmentsHelper(DrillSeparatePlanningTest.java:185) [test-classes/:na]
	at org.apache.drill.exec.DrillSeparatePlanningTest.testMultiMinorFragmentComplexQuery(DrillSeparatePlanningTest.java:108) [test-classes/:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_144]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_144]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_144]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_144]
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) [junit-4.11.jar:na]
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [junit-4.11.jar:na]
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) [junit-4.11.jar:na]
	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.executeTestMethod(JUnit4TestRunnerDecorator.java:120) [jmockit-1.3.jar:na]
	at mockit.integration.junit4.internal.JUnit4TestRunnerDecorator.invokeExplosively(JUnit4TestRunnerDecorator.java:65) [jmockit-1.3.jar:na]
	at mockit.integration.junit4.internal.MockFrameworkMethod.invokeExplosively(MockFrameworkMethod.java:29) [jmockit-1.3.jar:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_144]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_144]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_144]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_144]
	at mockit.internal.util.MethodReflection.invokeWithCheckedThrows(MethodReflection.java:95) [jmockit-1.3.jar:na]
	at mockit.internal.annotations.MockMethodBridge.callMock(MockMethodBridge.java:76) [jmockit-1.3.jar:na]
	at mockit.internal.annotations.MockMethodBridge.invoke(MockMethodBridge.java:41) [jmockit-1.3.jar:na]
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java) [junit-4.11.jar:na]
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [junit-4.11.jar:na]
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) [junit-4.11.jar:na]

Issue Links

• causes: DRILL-6286 Regression: incorrect reference to shutdown in drillbit.log
• links to: GitHub Pull Request #1023