Apache Drill
  1. Apache Drill
  2. DRILL-580

Drill logical or physical rules should not specify child operand

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Most of Drill logical and physical rules (implements RelOptRule) are essentially conversion rules. For conversion rule, it's not required to specify the child operand in the rule's pattern matching expression. However, currently, Drill logical or physical rules specify the child operand. This will cause unnecessary rule firing during optiq transformation call, causing more planning time.

      In stead, for conversion rule in Drill logical/physical phases, it would be sufficient enough to specify the parent operand.

        Activity

        Hide
        Jinfeng Ni added a comment -

        Rebase on the latest master. Run a clean build against testcase suite.

        Show
        Jinfeng Ni added a comment - Rebase on the latest master. Run a clean build against testcase suite.
        Hide
        Jacques Nadeau added a comment -

        Resolved in 0b9893c

        Show
        Jacques Nadeau added a comment - Resolved in 0b9893c

          People

          • Assignee:
            Jinfeng Ni
            Reporter:
            Jinfeng Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development