Apache Drill
  1. Apache Drill
  2. DRILL-580

Drill logical or physical rules should not specify child operand

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Most of Drill logical and physical rules (implements RelOptRule) are essentially conversion rules. For conversion rule, it's not required to specify the child operand in the rule's pattern matching expression. However, currently, Drill logical or physical rules specify the child operand. This will cause unnecessary rule firing during optiq transformation call, causing more planning time.

      In stead, for conversion rule in Drill logical/physical phases, it would be sufficient enough to specify the parent operand.

        Activity

        Jinfeng Ni created issue -
        Jinfeng Ni made changes -
        Field Original Value New Value
        Attachment DRILL-580.1.patch [ 12642158 ]
        Jake Farrell made changes -
        Workflow no-reopen-closed, patch-avail [ 12858241 ] no-reopen-closed, patch-avail, testing [ 12860101 ]
        Jinfeng Ni made changes -
        Attachment DRILL-580.1.patch [ 12642158 ]
        Jinfeng Ni made changes -
        Attachment DRILL-580.2.patch [ 12643620 ]
        Jacques Nadeau made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.4.0 [ 12324963 ]

          People

          • Assignee:
            Jinfeng Ni
            Reporter:
            Jinfeng Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development