Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-5712

Update the pom files with dependency exclusions for commons-codec

    Details

    • Type: Bug
    • Status: Reviewable
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Tools, Build & Test
    • Labels:
      None

      Description

      In java-exec, we are adding a dependency for commons-codec of version 1.10. Other dependencies like hadoop-common, parquet-column etc are trying to download different versions for common codec. Exclusions should be added for common-codec in these dependencies.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sindhurirayavaram opened a pull request:

          https://github.com/apache/drill/pull/903

          DRILL-5712: Update the pom files with dependency exclusions for commons-codec

          In java-exec, we are adding a dependency for commons-codec of version 1.10. Other dependencies like hadoop-common, parquet-column etc are trying to download different versions for common codec. Exclusions should be added for common-codec in these dependencies.
          This change has added exclusions in all the pom.xml files.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sindhurirayavaram/drill DRILL-5712

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/drill/pull/903.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #903


          commit 88389f83e7c786c47c907b73a086d677a224778a
          Author: Sindhuri Rayavaram <sindhurirayavaram@mapr.local>
          Date: 2017-08-10T19:50:58Z

          DRILL-5712: Update the pom files with dependency exclusions for commons-codec


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sindhurirayavaram opened a pull request: https://github.com/apache/drill/pull/903 DRILL-5712 : Update the pom files with dependency exclusions for commons-codec In java-exec, we are adding a dependency for commons-codec of version 1.10. Other dependencies like hadoop-common, parquet-column etc are trying to download different versions for common codec. Exclusions should be added for common-codec in these dependencies. This change has added exclusions in all the pom.xml files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sindhurirayavaram/drill DRILL-5712 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/903.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #903 commit 88389f83e7c786c47c907b73a086d677a224778a Author: Sindhuri Rayavaram <sindhurirayavaram@mapr.local> Date: 2017-08-10T19:50:58Z DRILL-5712 : Update the pom files with dependency exclusions for commons-codec
          Hide
          jni Jinfeng Ni added a comment -

          I'm seeing both failures in unit test and functional regression test. Please resolve those failures before we can get the patch merged. thx.

          Show
          jni Jinfeng Ni added a comment - I'm seeing both failures in unit test and functional regression test. Please resolve those failures before we can get the patch merged. thx.
          Hide
          jni Jinfeng Ni added a comment -

          Some of the unit testcases that failed:

          Tests in error:
          TestInfoSchemaOnHiveStorage>HiveTestBase.generateHive:34 » ExceptionInInitializer
          TestViewSupportOnHiveTables.generateHive:34 » ExceptionInInitializer
          TestHiveStorage.readingFromStorageHandleBasedTable2:430->BaseTestQuery.testRunAndReturn:344 » Rpc
          TestHiveStorage.testIgnoreSkipHeaderFooterForSequencefile:520->BaseTestQuery.testRunAndReturn:344 » Rpc
          TestHiveStorage.readingFromSmallTableWithSkipHeaderAndFooter:443 » org.apache...
          TestHiveStorage.testIgnoreSkipHeaderFooterForParquet:510->BaseTestQuery.testRunAndReturn:344 » Rpc
          TestHiveStorage.testNonAsciiStringLiterals:560->BaseTestQuery.testRunAndReturn:344 » Rpc
          TestHiveStorage.testIgnoreSkipHeaderFooterForRcfile:500->BaseTestQuery.testRunAndReturn:344 » Rpc
          TestHiveStorage.nativeReaderIsDisabledForAlteredPartitionedTable:408->PlanTestBase.getPlanInString:330-
          ...

          Show
          jni Jinfeng Ni added a comment - Some of the unit testcases that failed: Tests in error: TestInfoSchemaOnHiveStorage>HiveTestBase.generateHive:34 » ExceptionInInitializer TestViewSupportOnHiveTables.generateHive:34 » ExceptionInInitializer TestHiveStorage.readingFromStorageHandleBasedTable2:430->BaseTestQuery.testRunAndReturn:344 » Rpc TestHiveStorage.testIgnoreSkipHeaderFooterForSequencefile:520->BaseTestQuery.testRunAndReturn:344 » Rpc TestHiveStorage.readingFromSmallTableWithSkipHeaderAndFooter:443 » org.apache... TestHiveStorage.testIgnoreSkipHeaderFooterForParquet:510->BaseTestQuery.testRunAndReturn:344 » Rpc TestHiveStorage.testNonAsciiStringLiterals:560->BaseTestQuery.testRunAndReturn:344 » Rpc TestHiveStorage.testIgnoreSkipHeaderFooterForRcfile:500->BaseTestQuery.testRunAndReturn:344 » Rpc TestHiveStorage.nativeReaderIsDisabledForAlteredPartitionedTable:408->PlanTestBase.getPlanInString:330- ...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user paul-rogers commented on the issue:

          https://github.com/apache/drill/pull/903

          @sindhurirayavaram, please rebase this onto the latest master; looks like some stray commits have found their way into this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/903 @sindhurirayavaram, please rebase this onto the latest master; looks like some stray commits have found their way into this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user paul-rogers commented on the issue:

          https://github.com/apache/drill/pull/903

          @sindhurirayavaram, will you be able to rebase this & squash commits? Then I can merge it into master. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/903 @sindhurirayavaram, will you be able to rebase this & squash commits? Then I can merge it into master. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/drill/pull/903

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/903

            People

            • Assignee:
              sindhurir Sindhuri Ramanarayan Rayavaram
              Reporter:
              sindhurir Sindhuri Ramanarayan Rayavaram
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development