[DRILL-5159] ProjectMergeRule in Drill should operate on RelNodes with same convention trait.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: Query Planning & Optimization
• Labels: ready-to-commit
• Assignee: Jinfeng Ni
• Reporter: Jinfeng Ni
• Reviewer: Rahul Kumar Challapalli
• Created: 23/Dec/16 22:31
• Updated: 30/Mar/17 20:19
• Resolved: 04/Jan/17 21:44

Description

Drill extended version of Calcite's ProjectMergeRule is used in a VolcanoPlanner where RelNodes with different convention could match with this rule.

For instance, we could see this rule could be invoked when a DrillProject on top of a LogicalProject. Also, since the output RelNode is built from the default Project RelFactory, such rule execution could end up with a LogicalProject.

DrillProject                transform          
\                                  ===>               LogicalProject
LogicalProject

This leads to un-necessary rule execution, or in certain case could lead to an infinite loop.

The proposed fix is to check matched RelNodes to make sure that they do have Calcite Logical convention. That way, both inputs and output of this rule would have same convention trait. This should reduce planning time, and avoid the possiblity of loop.

Issue Links

• links to: GitHub Pull Request #705