[DRILL-5055] External Sort does not delete spill file if error occurs during close

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.11.0
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 21/Nov/16 16:34
• Updated: 28/Mar/17 20:13
• Resolved: 17/Feb/17 22:25

Description

DRILL-3898 recently fixed a case in which disk space was exhausted during a spill event for the external sort. In this case, the call to close failed because close attempted to flush remaining buffered data, but that also failed due to out of space.

While the fix works, the fix causes the partially-completed spill file to be left on disk. Consider this code in BatchGroup.close( )

    if (outputStream != null) {
      outputStream.close();
    }
    ...
    if (fs != null && fs.exists(path)) {
      fs.delete(path, false);
    }

Notice that, if the output stream close fails, the spill file is not deleted. The fix is to put the delete in a finally block so that it is always deleted.