[DRILL-5020] ExternalSortBatch has inconsistent notions of the memory limit

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.11.0
• Assignee: Paul Rogers
• Reporter: Paul Rogers
• Created: 09/Nov/16 00:55
• Updated: 28/Mar/17 20:15
• Resolved: 17/Feb/17 22:22

Description

The memory limit cases for the spill-needed test seem inconsistent:

For the test for in-memory sort:

    long currentlyAvailable =  popConfig.getMaxAllocation() - oAllocator.getAllocatedMemory();

For reaching the memory limit:

oAllocator.getAllocatedMemory() > .95 * oAllocator.getLimit()

That is, one uses oAllocator.getLimit ("the current maximum limit this allocator imposes"), the other uses popConfig.getMaxAllocation ("The maximum memory this operator can allocate".)