Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-4854

Incorrect logic in log directory checks in drill-config.sh

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      Description

      The recent changes to the launch scripts introduced a subtle bug in the logic that verifies the log directory:

      if [[ ! -d "$DRILL_LOG_DIR" && ! -w "$DRILL_LOG_DIR" ]]; then
      ...

      if [[ ! -d "$DRILL_LOG_DIR" && ! -w "$DRILL_LOG_DIR" ]]; then

      In both cases, the operator should be or ("||").

      That is, if either the item is not a directory, or it is a directory but is not writable, then do the fall-back steps.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                paul-rogers Paul Rogers
                Reporter:
                paul-rogers Paul Rogers
                Reviewer:
                Abhishek Girish
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: