Apache Drill
  1. Apache Drill
  2. DRILL-466

submit_plan failures does not terminate the program

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.1.0-m1
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Run submit_plan that will fail.

      The program does not terminate. You have to use Control-C to terminate it.

      1. DRILL-466.patch
        2 kB
        Bhallamudi Venkata Siva Kamesh
      2. DRILL-466_1.patch
        1 kB
        Bhallamudi Venkata Siva Kamesh

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        12d 7h 56m 1 Bhallamudi Venkata Siva Kamesh 09/Apr/14 07:23
        Patch Available Patch Available Resolved Resolved
        13d 20h 52m 1 Jacques Nadeau 23/Apr/14 04:15
        Tony Stevenson made changes -
        Workflow no-reopen-closed, patch-avail, testing [ 12859979 ] Drill workflow [ 12933457 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.4.0 [ 12324963 ]
        Jake Farrell made changes -
        Workflow no-reopen-closed, patch-avail [ 12851540 ] no-reopen-closed, patch-avail, testing [ 12859979 ]
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        Thanks Jacques for committing.

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - Thanks Jacques for committing.
        Jacques Nadeau made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jacques Nadeau added a comment -

        merged in 50cc90e

        Show
        Jacques Nadeau added a comment - merged in 50cc90e
        Bhallamudi Venkata Siva Kamesh made changes -
        Attachment DRILL-466_1.patch [ 12641211 ]
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        Thanks Steven and Jacques for reviewing the patch.

        Some of the code changes from my previous patch are already there in the code. So, updating the patch with necessary code changes.

        I think, it is better to continue on other queries. Please provide your comments. If required, we can handle this in another JIRA.

        Please go through the patch.

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - Thanks Steven and Jacques for reviewing the patch. Some of the code changes from my previous patch are already there in the code. So, updating the patch with necessary code changes. I think, it is better to continue on other queries. Please provide your comments. If required, we can handle this in another JIRA. Please go through the patch.
        Hide
        Jacques Nadeau added a comment -

        Fails to apply against latest master. Please update patch. Also, please use git format-patch so that patch can be imported with commit information. thanks!

        Show
        Jacques Nadeau added a comment - Fails to apply against latest master. Please update patch. Also, please use git format-patch so that patch can be imported with commit information. thanks!
        Hide
        Steven Phillips added a comment -

        I think this looks good. The only question I have is what to do in the case where multiple queries are submitted at once, which is allowed running SQL queries. Do we want exit after the first failure, or continue on to the other queries?

        Show
        Steven Phillips added a comment - I think this looks good. The only question I have is what to do in the case where multiple queries are submitted at once, which is allowed running SQL queries. Do we want exit after the first failure, or continue on to the other queries?
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        Can anyone please lookinto this patch

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - Can anyone please lookinto this patch
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        Can anyone please review this patch

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - Can anyone please review this patch
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        Can anyone review this patch provide comments

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - Can anyone review this patch provide comments
        Bhallamudi Venkata Siva Kamesh made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 1.0.0-milestone-1 [ 12324669 ]
        Bhallamudi Venkata Siva Kamesh made changes -
        Field Original Value New Value
        Attachment DRILL-466.patch [ 12639348 ]
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        Created a patch to fix this. With this patch, whenever submit_plan fails, process will be closed gracefully.

        Please review the patch and provide your comments.

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - Created a patch to fix this. With this patch, whenever submit_plan fails, process will be closed gracefully. Please review the patch and provide your comments.
        Hide
        Bhallamudi Venkata Siva Kamesh added a comment -

        I submitted a logical plan using submit_plan, which got failed and the process got hanged.
        By taking the thread dump, process got hanged at

        "WorkManager Event Thread" daemon prio=5 tid=0x00007faa01b44800 nid=0x6b07 waiting on condition [0x0000000117531000]
        	at org.apache.drill.exec.work.WorkManager$EventThread.run(WorkManager.java:171)
        

        I think, it got hanged because EventThread in WorkManager.java defined as daemon thread and it runs forever even though process exits.

        Show
        Bhallamudi Venkata Siva Kamesh added a comment - I submitted a logical plan using submit_plan, which got failed and the process got hanged. By taking the thread dump, process got hanged at "WorkManager Event Thread" daemon prio=5 tid=0x00007faa01b44800 nid=0x6b07 waiting on condition [0x0000000117531000] at org.apache.drill.exec.work.WorkManager$EventThread.run(WorkManager.java:171) I think, it got hanged because EventThread in WorkManager.java defined as daemon thread and it runs forever even though process exits.
        Zhiyong Liu created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Zhiyong Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development