Like most projects at apache Drill needs to have a coding style set up.
I'm basically using the HBase eclipse formatting styles for my work. Only difference is increasing maximum line length to 120. See http://hbase.apache.org/book.html#eclipse. How about we start with those and then update as necessary. Do you want to doc it on the Wiki?
+1 on those.
I'll update the wiki.
I've added a "Contributing" entry to the wiki that refers to HBase's page (unless you'd prefer to copy it).
I've also added links to formatter configuration files for IDEA and Eclipse that follow the HBase code conventions.
I've adapted (cough blatantly copie cough) the "Contributing" page from Hive and added our specifics (maven, git etc) and formatter configurations.
Those can be found at: https://cwiki.apache.org/confluence/display/DRILL/Contributing
Thanks for 'adapting' this. Couple things: we're using a later version of Junit (4.x) so the requirements are much less (just @Test annotation). For patch application, maybe update with instructions for git-am. We should also state use of review board for reviews and pull request as an alternative to attached patch for simple changes.
I'll update the page wrt to junit and reviewboard.
With regard to pull requests (with patch extension) I think they are great for WIP reviews but that we should refrain from using them for patches of any kind. The reasoning is that, because the patch is dynamically generated based on the curent diff, the pull requester could change the patch at any time after the review and before the merge.
Fair point on patches.
Updated the "Contributing" page to address Jacques comments, namely:
Please Review, and/or +1 so that I can close.
Good for now