Apache Drill
  1. Apache Drill
  2. DRILL-375

VarBinary hash function computing hash for entire buffer

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      the hash function for VarBinary data type should be computing the hash function for a particular record. But it is currently computing for the entire buffer, which is all of the data for the ValueVector.

      the fix is to set the starting and ending indices for the particular value.

      1. DRILL-375.patch
        1 kB
        Steven Phillips
      2. DRILL-375
        1 kB
        Steven Phillips

        Activity

        Steven Phillips created issue -
        Hide
        Steven Phillips added a comment -

        Compute hash function on buffer starting and ending at the correct indices.

        Show
        Steven Phillips added a comment - Compute hash function on buffer starting and ending at the correct indices.
        Steven Phillips made changes -
        Field Original Value New Value
        Attachment DRILL-375 [ 12629967 ]
        Hide
        Jason Altekruse added a comment -

        patch is saved with .html extension. I doubt git will care, but when trying to view the patch in the browser it removes all of the whitespace and smashes all of the text together.

        Show
        Jason Altekruse added a comment - patch is saved with .html extension. I doubt git will care, but when trying to view the patch in the browser it removes all of the whitespace and smashes all of the text together.
        Hide
        Timothy Chen added a comment -

        It's hard to understand the patch, and can't really apply this too.
        Reviewboard?

        Show
        Timothy Chen added a comment - It's hard to understand the patch, and can't really apply this too. Reviewboard?
        Steven Phillips made changes -
        Attachment DRILL-375.patch [ 12630012 ]
        Hide
        Jacques Nadeau added a comment -

        Added in 08bc16d

        Show
        Jacques Nadeau added a comment - Added in 08bc16d
        Jacques Nadeau made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Jake Farrell made changes -
        Workflow no-reopen-closed, patch-avail [ 12843256 ] no-reopen-closed, patch-avail, testing [ 12860146 ]
        Jacques Nadeau made changes -
        Fix Version/s 0.4.0 [ 12324963 ]

          People

          • Assignee:
            Steven Phillips
            Reporter:
            Steven Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development