[DRILL-362] Some protobuf enum values generates problematic C++/Windows code

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Fix Version/s: 0.4.0
• Assignee: Unassigned
• Reporter: George Chow
• Created: 07/Feb/14 21:47
• Updated: 31/Jul/14 06:32
• Resolved: 28/May/14 23:02

Description

The enums DataMode and MinorType (in Types.proto) each contain a value (OPTIONAL and NULL respectively) that generate into problematic C++ code on Windows under Visual Studio.

I propose to add a prefix to the enum values to uniquify them. For example:

enum DataMode {
DM_OPTIONAL = 0,
DM_REQUIRED = 1,
DM_REPEATED = 2
}

This is slightly ugly but is ultimately safe. Unfortunately, this change will trigger a lot of little changes throughout the codebase.

Issue Links

• relates to: DRILL-371 Build Drill C++ client driver