[DRILL-3448] typo in QueryManager.DrillbitStatusListener will cause the Foreman to hang if a Drillbit dies

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.2.0
• Component/s: Execution - Flow
• Assignee: Khurram Faraaz
• Reporter: Abdel Hakim Deneche
• Created: 01/Jul/15 22:26
• Updated: 06/Oct/15 17:53
• Resolved: 11/Sep/15 15:51

Description

at the end of DrillbitStatusListener.drillbitUnregistered() there is if block:

      if (!atLeastOneFailure) {
        logger.warn("...");
        stateListener.moveToState(QueryState.FAILED,
            new ForemanException(...));
      }

this will basically fail the query if the drillbit DIDN'T contain any fragment for this Foreman, which in fact should be the inverse.

Issue Links

• is part of: DRILL-3455 If a drillbit, that contains fragments for the current query, dies the QueryManager will fail the query even if those fragments already finished successfully