[DRILL-3445] BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.2.0
• Component/s: Execution - Data Types, Execution - Relational Operators
• Assignee: Abdel Hakim Deneche
• Reporter: Abdel Hakim Deneche
• Created: 01/Jul/15 14:34
• Updated: 06/Jul/15 23:40
• Resolved: 06/Jul/15 23:40

Description

current implementations of BufferAllocator.buffer() return null if it can't allocate the buffer because of direct memory or fragment limits., but many places in the code don't actually check if the buffer is null before trying to access it, this will result in confusing NullPointerException(s) when we are in fact running out of memory.

We should change the implementations to throw an OutOfMemoryRuntimeException instead. Drill already handles this exception properly in most cases and displays a proper error message to the user.

Issue Links

• contains: DRILL-3312 PageReader.allocatePageData() calls BufferAllocator.buffer(int) but doesn't check if the result is null
• duplicates: DRILL-3312 PageReader.allocatePageData() calls BufferAllocator.buffer(int) but doesn't check if the result is null
• is depended upon by: DRILL-2974 Make OutOfMemoryException an unchecked exception and remove OutOfMemoryRuntimeException
• is related to: DRILL-2974 Make OutOfMemoryException an unchecked exception and remove OutOfMemoryRuntimeException