Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      Implement changes needed to support decimal type.

      Currently working on coming up with a good way to represent the decimal type in our Holders. The idea is to have the representation in our holders such that implementing functions for the decimal type would be easy.

      1. DRILL-332.patch
        286 kB
        Mehant Baid

        Activity

        Hide
        ASF GitHub Bot added a comment -

        Github user mehant closed the pull request at:

        https://github.com/apache/incubator-drill/pull/37

        Show
        ASF GitHub Bot added a comment - Github user mehant closed the pull request at: https://github.com/apache/incubator-drill/pull/37
        Hide
        ASF GitHub Bot added a comment -

        Github user mehant commented on the pull request:

        https://github.com/apache/incubator-drill/pull/37#issuecomment-42270010

        merged as a5ee8f84653d3dff64d83821fc14007514493382

        Show
        ASF GitHub Bot added a comment - Github user mehant commented on the pull request: https://github.com/apache/incubator-drill/pull/37#issuecomment-42270010 merged as a5ee8f84653d3dff64d83821fc14007514493382
        Hide
        ASF GitHub Bot added a comment -

        Github user jacques-n commented on the pull request:

        https://github.com/apache/incubator-drill/pull/37#issuecomment-42120545

        please close, this has been merged.

        Show
        ASF GitHub Bot added a comment - Github user jacques-n commented on the pull request: https://github.com/apache/incubator-drill/pull/37#issuecomment-42120545 please close, this has been merged.
        Hide
        Jacques Nadeau added a comment -

        merged in a5ee8f8

        Show
        Jacques Nadeau added a comment - merged in a5ee8f8
        Hide
        Mehant Baid added a comment -

        Rebased patch on top of latest master.

        Show
        Mehant Baid added a comment - Rebased patch on top of latest master.
        Hide
        Steven Phillips added a comment -

        Ship it!

        Show
        Steven Phillips added a comment - Ship it!
        Hide
        Mehant Baid added a comment -

        Updated to latest master
        Added SQL integration for decimal data type
        Added Cast functions from float, double to decimal and vice versa

        Show
        Mehant Baid added a comment - Updated to latest master Added SQL integration for decimal data type Added Cast functions from float, double to decimal and vice versa
        Hide
        ASF GitHub Bot added a comment -

        Github user mehant commented on the pull request:

        https://github.com/apache/incubator-drill/pull/37#issuecomment-39622749

        Updated pull request with the following changes.
        Rebased to latest master.
        Added support for SQL integration for decimal data type.

        Show
        ASF GitHub Bot added a comment - Github user mehant commented on the pull request: https://github.com/apache/incubator-drill/pull/37#issuecomment-39622749 Updated pull request with the following changes. Rebased to latest master. Added support for SQL integration for decimal data type.
        Hide
        ASF GitHub Bot added a comment -

        Github user mehant commented on the pull request:

        https://github.com/apache/incubator-drill/pull/37#issuecomment-38859056

        Updated patch to use SwappedByteBuf to have the same endianness for the buffers used in workspace variables and buffers in the ValueVectors.
        Enabled the tests for Decimal.

        Show
        ASF GitHub Bot added a comment - Github user mehant commented on the pull request: https://github.com/apache/incubator-drill/pull/37#issuecomment-38859056 Updated patch to use SwappedByteBuf to have the same endianness for the buffers used in workspace variables and buffers in the ValueVectors. Enabled the tests for Decimal.
        Hide
        Mehant Baid added a comment -

        Updated patch with the following.

        Conversion from VarChar and Int to Decimal and vice versa
        Unit tests.

        Show
        Mehant Baid added a comment - Updated patch with the following. Conversion from VarChar and Int to Decimal and vice versa Unit tests.
        Hide
        ASF GitHub Bot added a comment -

        GitHub user mehant opened a pull request:

        https://github.com/apache/incubator-drill/pull/37

        DRILL-332 Changes to support decimal data type

        Changes include the following:

        ValueVector, Holder representation for decimal types.
        Cast functions between various decimal types.
        Cast functions between Int, VarChar and decimal types.
        Unit tests

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/mehant/incubator-drill DRILL-332

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-drill/pull/37.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #37


        commit 1f4dcbaf4891046546ff6dd1dd81a7404e4a280e
        Author: Mehant Baid <mehantr@gmail.com>
        Date: 2014-03-27T18:48:40Z

        DRILL-332 Changes to support decimal data type


        Show
        ASF GitHub Bot added a comment - GitHub user mehant opened a pull request: https://github.com/apache/incubator-drill/pull/37 DRILL-332 Changes to support decimal data type Changes include the following: ValueVector, Holder representation for decimal types. Cast functions between various decimal types. Cast functions between Int, VarChar and decimal types. Unit tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/mehant/incubator-drill DRILL-332 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-drill/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit 1f4dcbaf4891046546ff6dd1dd81a7404e4a280e Author: Mehant Baid <mehantr@gmail.com> Date: 2014-03-27T18:48:40Z DRILL-332 Changes to support decimal data type
        Hide
        Jacques Nadeau added a comment -

        Please rebase on latest master, complete reviews and then transition to Patch Available.

        Show
        Jacques Nadeau added a comment - Please rebase on latest master, complete reviews and then transition to Patch Available.
        Hide
        Mehant Baid added a comment -
        Show
        Mehant Baid added a comment - Link to reviewboard: https://reviews.apache.org/r/16738/
        Hide
        Mehant Baid added a comment -

        Revised patch that contains the design changes for decimal representation.

        Show
        Mehant Baid added a comment - Revised patch that contains the design changes for decimal representation.
        Hide
        Mehant Baid added a comment -
        Show
        Mehant Baid added a comment - Link to design note for implementing decimal type: https://docs.google.com/document/d/1koDaE4CviLWpKyfdNFQZ6PqkFbbwXC45lGtehcihVmQ/edit?usp=sharing

          People

          • Assignee:
            Mehant Baid
            Reporter:
            Mehant Baid
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development