[DRILL-3312] PageReader.allocatePageData() calls BufferAllocator.buffer(int) but doesn't check if the result is null

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 1.2.0
• Component/s: Storage - Parquet
• Assignee: Abdel Hakim Deneche
• Reporter: Abdel Hakim Deneche
• Created: 18/Jun/15 19:12
• Updated: 02/Jul/15 17:28
• Resolved: 02/Jul/15 17:28

Description

Trying to reproduce DRILL-3241, Drill returns the following error:

SYSTEM ERROR: org.apache.drill.common.exceptions.DrillRuntimeException: Error in parquet record reader.
Message: 
Hadoop path: /Users/hakim/MapR/data/tpcds100/parquet/store_sales/1_10_1.parquet
Total records read: 0
Mock records read: 0
Records to read: 21845
Row group index: 0
Records in row group: 3348801
Parquet Metadata: ParquetMetaData{FileMetaData{schema: message root {
   ...omitted text
}
, metadata: {}}, blocks: [...omitted text]}

Fragment 3:0

[Error Id: 0f9ba088-3091-4166-b46f-53ab60d364f8 on 10.250.50.54:31010]

The logs contain more information about the cause:

Caused by: java.lang.NullPointerException
	at org.apache.drill.exec.store.parquet.DirectCodecFactory$FullDirectDecompressor.decompress(DirectCodecFactory.java:238) ~[drill-java-exec-1.1.0-SNAPSHOT-rebuffed.jar:1.1.0-SNAPSHOT]
	at org.apache.drill.exec.store.parquet.columnreaders.PageReader.next(PageReader.java:230) ~[drill-java-exec-1.1.0-SNAPSHOT-rebuffed.jar:1.1.0-SNAPSHOT]
	at org.apache.drill.exec.store.parquet.columnreaders.NullableColumnReader.processPages(NullableColumnReader.java:76) ~[drill-java-exec-1.1.0-SNAPSHOT-rebuffed.jar:1.1.0-SNAPSHOT]
	at org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader.readAllFixedFields(ParquetRecordReader.java:380) ~[drill-java-exec-1.1.0-SNAPSHOT-rebuffed.jar:1.1.0-SNAPSHOT]
	at org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader.next(ParquetRecordReader.java:423) ~[drill-java-exec-1.1.0-SNAPSHOT-rebuffed.jar:1.1.0-SNAPSHOT]
   ...

Just before that line, PageReader.next() calls the following method:

  private void allocatePageData(int size) {
    Preconditions.checkArgument(pageData == null);
    pageData = parentColumnReader.parentReader.getOperatorContext().getAllocator().buffer(size);
  }

this method should check the output of BufferAllocator.buffer(int) to make sure the buffer was successfully allocated.

Issue Links

• Is contained by: DRILL-3445 BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException
• is duplicated by: DRILL-3445 BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException
• is related to: DRILL-3241 Query with window function runs out of direct memory and does not report back to client that it did