[DRILL-3167] When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Future
• Assignee: Vitalii Diravka
• Reporter: Abdel Hakim Deneche
• Created: 22/May/15 03:05
• Updated: 03/Nov/21 13:20
• Resolved: 03/Nov/21 13:20

Description

TestDrillbitResilience.foreman_runTryEnd() exposes this problem intermittently

The query fails and the Foreman reports the failure to the client which removes the results listener associated to the failed query.
Sometimes, a data batch reaches the client after the FAILED state already arrived, the client doesn't handle this properly and the corresponding buffer is never released.

Making the Foreman wait for all fragments to finish before sending the final state should help avoid such scenarios.

Issue Links

• contains: DRILL-2699 Collect all cleanup errors before reporting a failure to the client
• duplicates: DRILL-3163 Fix hang/ leak issue exposed by TestDrillbitResilience#foreman_runTryEnd
• duplicates: DRILL-2699 Collect all cleanup errors before reporting a failure to the client
• is fixed by: DRILL-7973 Fix GitHub CI intermittent failures
• is fixed by: DRILL-8030 Intermittent TestDrillbitResilience cancelInMiddleOfFetchingResults and foreman_runTryEnd failures
• relates to: DRILL-3194 TestDrillbitResilience#memoryLeaksWhenFailed hangs