[DRILL-3122] Changing a session option to default value results in status as changed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.2.0
• Component/s: Query Planning & Optimization
• Assignee: Sudheesh Katkam
• Reporter: Ramana Inukonda Nagaraj
• Created: 17/May/15 22:27
• Updated: 03/Sep/15 23:45
• Resolved: 04/Aug/15 22:49

Description

Alter session option hash join to true(which is the default) and the following query shows that the option has changed which could be misleading to users relying on the status field to see if an option has changed or not. Especially in the case of a boolean value.

0: jdbc:drill:zk=10.10.100.171:5181> select * from sys.options where name like '%hash%';
+--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
|                    name                    |   kind   |  type   |  status  |   num_val   | string_val  | bool_val  | float_val  |
+--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
| exec.max_hash_table_size                   | LONG     | SYSTEM  | DEFAULT  | 1073741824  | null        | null      | null       |
| exec.min_hash_table_size                   | LONG     | SYSTEM  | DEFAULT  | 65536       | null        | null      | null       |
| planner.enable_hash_single_key             | BOOLEAN  | SYSTEM  | DEFAULT  | null        | null        | true      | null       |
| planner.enable_hashagg                     | BOOLEAN  | SYSTEM  | DEFAULT  | null        | null        | true      | null       |
| planner.enable_hashjoin                    | BOOLEAN  | SYSTEM  | DEFAULT  | null        | null        | true      | null       |
| planner.enable_hashjoin_swap               | BOOLEAN  | SYSTEM  | DEFAULT  | null        | null        | true      | null       |
| planner.join.hash_join_swap_margin_factor  | DOUBLE   | SYSTEM  | DEFAULT  | null        | null        | null      | 10.0       |
| planner.memory.hash_agg_table_factor       | DOUBLE   | SYSTEM  | DEFAULT  | null        | null        | null      | 1.1        |
| planner.memory.hash_join_table_factor      | DOUBLE   | SYSTEM  | DEFAULT  | null        | null        | null      | 1.1        |
+--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
9 rows selected (0.191 seconds)
0: jdbc:drill:zk=10.10.100.171:5181> alter session set `planner.enable_hashjoin`=true;
+-------+-----------------------------------+
|  ok   |              summary              |
+-------+-----------------------------------+
| true  | planner.enable_hashjoin updated.  |
+-------+-----------------------------------+
1 row selected (0.083 seconds)
0: jdbc:drill:zk=10.10.100.171:5181> select * from sys.options where name like '%hash%';
+--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
|                    name                    |   kind   |   type   |  status  |   num_val   | string_val  | bool_val  | float_val  |
+--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
| exec.max_hash_table_size                   | LONG     | SYSTEM   | DEFAULT  | 1073741824  | null        | null      | null       |
| exec.min_hash_table_size                   | LONG     | SYSTEM   | DEFAULT  | 65536       | null        | null      | null       |
| planner.enable_hash_single_key             | BOOLEAN  | SYSTEM   | DEFAULT  | null        | null        | true      | null       |
| planner.enable_hashagg                     | BOOLEAN  | SYSTEM   | DEFAULT  | null        | null        | true      | null       |
| planner.enable_hashjoin                    | BOOLEAN  | SYSTEM   | DEFAULT  | null        | null        | true      | null       |
| planner.enable_hashjoin                    | BOOLEAN  | SESSION  | CHANGED  | null        | null        | true      | null       |
| planner.enable_hashjoin_swap               | BOOLEAN  | SYSTEM   | DEFAULT  | null        | null        | true      | null       |
| planner.join.hash_join_swap_margin_factor  | DOUBLE   | SYSTEM   | DEFAULT  | null        | null        | null      | 10.0       |
| planner.memory.hash_agg_table_factor       | DOUBLE   | SYSTEM   | DEFAULT  | null        | null        | null      | 1.1        |
| planner.memory.hash_join_table_factor      | DOUBLE   | SYSTEM   | DEFAULT  | null        | null        | null      | 1.1        |
+--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+

Issue Links

• is duplicated by: DRILL-3287 Changing session level parameter back to the default value does not change it's status back to DEFAULT