Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-2923

Ensure all unit tests pass without assertions enabled

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: Execution - Flow
    • Labels:
      None

      Description

      I recently discovered that the test TestValueVector.java only passes if assertions are enabled (-ea to the JVM). This means that there are conditions which will fail in the wild, because production users don't run with assertions enabled. Someone needs to do a test run of mvn install with the -ea removed from the surefire command line and make sure that everything passes, and if not, we should fix them. We should also find a way to do this periodically, as part of CI, or as part of our regular test suites.

        Attachments

        1. DRILL-2923.1.patch.txt
          121 kB
          Chris Westin

          Issue Links

            Activity

              People

              • Assignee:
                jaltekruse Jason Altekruse
                Reporter:
                cwestin Chris Westin
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: