[DRILL-2837] Resolve what Statement.cancel() really should do

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: Client - JDBC
• Assignee: Daniel Barclay
• Reporter: Daniel Barclay
• Created: 21/Apr/15 17:26
• Updated: 30/Sep/15 06:16
• Resolved: 09/Jun/15 17:01

Description

It is not clear exactly what JDBC's Statement.cancel() method is supposed to do.

The Javadoc method description for cancel() says only:

Cancels this Statement object if both the DBMS and driver support aborting an SQL statement. This method can be used by one thread to cancel a statement that is being executed by another thread.

In particular, it's not clear what "cancels this Statement" really means. (The JDBC PDF specification doesn't anything about it.)

 
It seems reasonable to think that calling cancel() on a Statement cancels any associated query that has not already completed, leaves any associated ResultSet closed, and -leaves the statement closed-.

However, JDBC doesn't actually specify any of that, AvaticaStatement.cancel() does not close the Statement, and it's not clear whether SQLLine expects the above interpretation or not.

Issue Links

• is superceded by: DRILL-2884 Have cancel() cause "query canceled" rather than just "ResultSet closed"